From: Junio C Hamano <gitster@pobox•com>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail•com>
Cc: git@vger•kernel.org, Brad Smith <brad@comstyle•com>,
"brian m. carlson" <sandals@crustytoothpaste•net>
Subject: Re: [PATCH v3] config.mak.uname: update settings for FreeBSD
Date: Thu, 12 Jun 2025 15:37:49 -0700 [thread overview]
Message-ID: <xmqqjz5gbn7m.fsf@gitster.g> (raw)
In-Reply-To: <4fi5rwhpavu3se3htd2s4ym7oppswrwam545vczwf2jvumeqs3@z7imdc7cdw52> ("Carlo Marcelo Arenas Belón"'s message of "Thu, 12 Jun 2025 15:30:59 -0700")
Carlo Marcelo Arenas Belón <carenas@gmail•com> writes:
> I was hoping something more like with the following (untested) "fixup"
> on toa, obviously the "unconditionally" in the commit message should
> need adding "for the supported versions"
>
> diff --git a/config.mak.uname b/config.mak.uname
> index 9cac400d94..cbf1f4c0d2 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -280,6 +280,9 @@ ifeq ($(uname_S),FreeBSD)
> ifeq ($(firstword $(subst -, ,$(uname_R))),10.1)
> OLD_ICONV = YesPlease
> endif
> + ifeq ($(shell test "`expr "$(uname_R)" : '\([1-9][0-9]*\)\.'`" -lt 12 && echo 1),1)
> + NO_MEMMEM = UnfortunatelyYes
> + endif
> BASIC_CFLAGS += -I/usr/local/include
> BASIC_LDFLAGS += -L/usr/local/lib
> DIR_HAS_BSD_GROUP_SEMANTICS = YesPlease
>
> Note that either way the build won't be broken
As I do not think we quite care about anything older than 12, I am
perfectly fine being a bit extra defensive like your version.
Care to assemble the final version with both code and log message
updates? We are not in a hurry, as we are talking about a rather
ancient issue and this will not come close to 'master' before the
final release next week anyway.
Thanks.
next prev parent reply other threads:[~2025-06-12 22:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 13:52 [PATCH v2] config.mak.uname: update settings for FreeBSD Carlo Arenas
2025-06-12 16:48 ` brian m. carlson
2025-06-12 21:31 ` Carlo Marcelo Arenas Belón
2025-06-12 21:51 ` [PATCH v3] " Junio C Hamano
2025-06-12 22:30 ` Carlo Marcelo Arenas Belón
2025-06-12 22:37 ` Junio C Hamano [this message]
2025-07-02 9:37 ` [PATCH v4 0/2] " Carlo Marcelo Arenas Belón
2025-07-02 9:37 ` [PATCH v4 1/2] config.mak.uname: set NO_MEMMEM only for functional version Carlo Marcelo Arenas Belón
2025-07-02 9:37 ` [PATCH v4 2/2] build: retire NO_UINTMAX_T Carlo Marcelo Arenas Belón
2025-07-02 16:21 ` [PATCH v4 0/2] config.mak.uname: update settings for FreeBSD Junio C Hamano
2025-06-12 16:52 ` [PATCH v2] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqjz5gbn7m.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=brad@comstyle$(echo .)com \
--cc=carenas@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=sandals@crustytoothpaste$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox