From: Patrick Steinhardt <ps@pks•im>
To: "René Scharfe" <l.s.r@web•de>
Cc: Git List <git@vger•kernel.org>
Subject: Re: [PATCH v2 2/7] parse-options: add precision handling for PARSE_OPT_CMDMODE
Date: Wed, 9 Jul 2025 17:58:01 +0200 [thread overview]
Message-ID: <aG6RidvxUqV25Fli@pks.im> (raw)
In-Reply-To: <144ecb24-4da2-4311-bf26-3101788f4b12@web.de>
On Wed, Jul 09, 2025 at 05:05:35PM +0200, René Scharfe wrote:
> On 7/9/25 3:58 PM, Patrick Steinhardt wrote:
> > On Wed, Jul 09, 2025 at 11:45:14AM +0200, René Scharfe wrote:
> >>
> >> Call the function that does the raw casting do_get_int_value() to
> >> reserve the name get_int_value() for a more friendly wrapper we're
> >> going to introduce in one of the next patches.
>
> >> diff --git a/parse-options.c b/parse-options.c
> >> index 68ff494492..ddac008a5e 100644
> >> --- a/parse-options.c
> >> +++ b/parse-options.c
> >> @@ -68,6 +68,26 @@ static char *fix_filename(const char *prefix, const char *file)
> >> return prefix_filename_except_for_dash(prefix, file);
> >> }
> >>
> >> +static int do_get_int_value(const void *value, size_t precision, intmax_t *ret)
> >
> > Nit: after the fourth patch we have `do_get_int_value()` and
> > `get_int_value()`, where the major difference is that the latter dies if
> > we failed to parse the value. It might be easier to discern which is
> > which if we called them `get_int_value()` and `get_int_value_or_die()`.
>
> That would be misleading because get_int_value() doesn't die() like a
> function from write-or-die.c, it BUGs instead. I don't think it makes
> sense to advertise the presence of assertions in a function's name.
> But we do have a tradition of using a prefix of "do_" with wrapped
> functions that have a more raw interface and do the actual work.
>
> Nit: They don't parse, but cast a void pointer to the appropriate type
> and dereference it.
Fair enough. I don't mind it much either way, thanks!
Patrick
next prev parent reply other threads:[~2025-07-09 15:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-29 11:43 [PATCH 0/6] parse-options: add more precision handling René Scharfe
2025-06-29 11:50 ` [PATCH 1/6] parse-options: add precision handling for PARSE_OPT_CMDMODE René Scharfe
2025-07-01 10:55 ` Patrick Steinhardt
2025-07-01 15:15 ` René Scharfe
2025-06-29 11:50 ` [PATCH 2/6] parse-options: add precision handling for OPTION_SET_INT René Scharfe
2025-07-01 10:55 ` Patrick Steinhardt
2025-07-01 15:54 ` René Scharfe
2025-07-02 2:31 ` Patrick Steinhardt
2025-06-29 11:50 ` [PATCH 3/6] parse-options: add precision handling for OPTION_BIT René Scharfe
2025-06-29 11:51 ` [PATCH 4/6] parse-options: add precision handling for OPTION_NEGBIT René Scharfe
2025-06-29 11:51 ` [PATCH 5/6] parse-options: add precision handling for OPTION_BITOP René Scharfe
2025-07-01 10:55 ` Patrick Steinhardt
2025-07-01 15:21 ` René Scharfe
2025-07-02 2:33 ` Patrick Steinhardt
2025-06-29 11:51 ` [PATCH 6/6] parse-options: add precision handling for OPTION_COUNTUP René Scharfe
2025-07-01 10:55 ` Patrick Steinhardt
2025-07-01 16:01 ` René Scharfe
2025-07-02 2:29 ` Patrick Steinhardt
2025-07-09 9:26 ` [PATCH v2 0/7] parse-options: add more precision handling René Scharfe
2025-07-09 9:44 ` [PATCH v2 1/7] parse-options: require PARSE_OPT_NOARG for OPTION_BITOP René Scharfe
2025-07-09 13:59 ` Patrick Steinhardt
2025-07-09 9:45 ` [PATCH v2 2/7] parse-options: add precision handling for PARSE_OPT_CMDMODE René Scharfe
2025-07-09 13:58 ` Patrick Steinhardt
2025-07-09 15:05 ` René Scharfe
2025-07-09 15:58 ` Patrick Steinhardt [this message]
2025-07-09 15:56 ` Junio C Hamano
2025-07-09 9:45 ` [PATCH v2 3/7] parse-options: add precision handling for OPTION_SET_INT René Scharfe
2025-07-09 9:45 ` [PATCH v2 4/7] parse-options: add precision handling for OPTION_BIT René Scharfe
2025-07-09 9:45 ` [PATCH v2 5/7] parse-options: add precision handling for OPTION_NEGBIT René Scharfe
2025-07-09 9:46 ` [PATCH v2 6/7] parse-options: add precision handling for OPTION_BITOP René Scharfe
2025-07-09 9:46 ` [PATCH v2 7/7] parse-options: add precision handling for OPTION_COUNTUP René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aG6RidvxUqV25Fli@pks.im \
--to=ps@pks$(echo .)im \
--cc=git@vger$(echo .)kernel.org \
--cc=l.s.r@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox