From: "René Scharfe" <l.s.r@web•de>
To: Patrick Steinhardt <ps@pks•im>
Cc: Git List <git@vger•kernel.org>
Subject: Re: [PATCH 2/6] parse-options: add precision handling for OPTION_SET_INT
Date: Tue, 1 Jul 2025 17:54:41 +0200 [thread overview]
Message-ID: <fb50bdea-f529-447a-9cf1-0fbde3f8e22e@web.de> (raw)
In-Reply-To: <aGO-l81JiOESvbS9@pks.im>
On 7/1/25 12:55 PM, Patrick Steinhardt wrote:
> On Sun, Jun 29, 2025 at 01:50:39PM +0200, René Scharfe wrote:
>> diff --git a/parse-options.c b/parse-options.c
>> index da07a000a3..bbb68603cc 100644
>> --- a/parse-options.c
>> +++ b/parse-options.c
>> @@ -85,6 +85,36 @@ static intmax_t get_int_value(const struct option *opt)
>> }
>> }
>>
>> +static enum parse_opt_result set_int_value(const struct option *opt,
>> + enum opt_parsed flags,
>> + intmax_t value)
>> +{
>> + switch (opt->precision) {
>> + case sizeof(int8_t):
>> + *(int8_t *)opt->value = value;
>> + return 0;
>> + case sizeof(int16_t):
>> + *(int16_t *)opt->value = value;
>> + return 0;
>> + case sizeof(int32_t):
>> + *(int32_t *)opt->value = value;
>> + return 0;
>> + case sizeof(int64_t):
>> + *(int64_t *)opt->value = value;
>> + return 0;
>> + default:
>> + BUG("invalid precision for option %s", optname(opt, flags));
>> + }
>> +}
>
> The function only ever dies or returns successfully, so can't we make it
> return nothing instead? On the other hand it does make a couple of
> callsites a bit nicer to read.
We can. Not sure we should, obviously, but I don't have strong feelings
either way.
>
>> +static int signed_int_fits(intmax_t value, size_t size)
>> +{
>> + size_t bits = size * CHAR_BIT;
>> + intmax_t upper_bound = INTMAX_MAX >> (bitsizeof(intmax_t) - bits);
>> + intmax_t lower_bound = -upper_bound - 1;
>> + return lower_bound <= value && value <= upper_bound;
>> +}
>> +
>
> Should we s/size/precision/ so that it's clear what kind of size this
> exactly is?
It's the width of an integer variable as in sizeof(), so the name fits.
We can inline this single-caller function if it's indeed confusing.
René
next prev parent reply other threads:[~2025-07-01 15:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-29 11:43 [PATCH 0/6] parse-options: add more precision handling René Scharfe
2025-06-29 11:50 ` [PATCH 1/6] parse-options: add precision handling for PARSE_OPT_CMDMODE René Scharfe
2025-07-01 10:55 ` Patrick Steinhardt
2025-07-01 15:15 ` René Scharfe
2025-06-29 11:50 ` [PATCH 2/6] parse-options: add precision handling for OPTION_SET_INT René Scharfe
2025-07-01 10:55 ` Patrick Steinhardt
2025-07-01 15:54 ` René Scharfe [this message]
2025-07-02 2:31 ` Patrick Steinhardt
2025-06-29 11:50 ` [PATCH 3/6] parse-options: add precision handling for OPTION_BIT René Scharfe
2025-06-29 11:51 ` [PATCH 4/6] parse-options: add precision handling for OPTION_NEGBIT René Scharfe
2025-06-29 11:51 ` [PATCH 5/6] parse-options: add precision handling for OPTION_BITOP René Scharfe
2025-07-01 10:55 ` Patrick Steinhardt
2025-07-01 15:21 ` René Scharfe
2025-07-02 2:33 ` Patrick Steinhardt
2025-06-29 11:51 ` [PATCH 6/6] parse-options: add precision handling for OPTION_COUNTUP René Scharfe
2025-07-01 10:55 ` Patrick Steinhardt
2025-07-01 16:01 ` René Scharfe
2025-07-02 2:29 ` Patrick Steinhardt
2025-07-09 9:26 ` [PATCH v2 0/7] parse-options: add more precision handling René Scharfe
2025-07-09 9:44 ` [PATCH v2 1/7] parse-options: require PARSE_OPT_NOARG for OPTION_BITOP René Scharfe
2025-07-09 13:59 ` Patrick Steinhardt
2025-07-09 9:45 ` [PATCH v2 2/7] parse-options: add precision handling for PARSE_OPT_CMDMODE René Scharfe
2025-07-09 13:58 ` Patrick Steinhardt
2025-07-09 15:05 ` René Scharfe
2025-07-09 15:58 ` Patrick Steinhardt
2025-07-09 15:56 ` Junio C Hamano
2025-07-09 9:45 ` [PATCH v2 3/7] parse-options: add precision handling for OPTION_SET_INT René Scharfe
2025-07-09 9:45 ` [PATCH v2 4/7] parse-options: add precision handling for OPTION_BIT René Scharfe
2025-07-09 9:45 ` [PATCH v2 5/7] parse-options: add precision handling for OPTION_NEGBIT René Scharfe
2025-07-09 9:46 ` [PATCH v2 6/7] parse-options: add precision handling for OPTION_BITOP René Scharfe
2025-07-09 9:46 ` [PATCH v2 7/7] parse-options: add precision handling for OPTION_COUNTUP René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb50bdea-f529-447a-9cf1-0fbde3f8e22e@web.de \
--to=l.s.r@web$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox