public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste•net>
To: Ashlesh Gawande <git@ashlesh•me>
Cc: git@vger•kernel.org, "Patrick Steinhardt" <ps@pks•im>,
	"Junio C Hamano" <gitster@pobox•com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
Subject: Re: [PATCH] http.c: prompt for username on 403
Date: Wed, 15 Oct 2025 22:31:58 +0000	[thread overview]
Message-ID: <aPAg3gYwzA9fHCC3@fruit.crustytoothpaste.net> (raw)
In-Reply-To: <30639771-4999-45f4-a8d7-1ed4774ffd8e@ashlesh.me>

[-- Attachment #1: Type: text/plain, Size: 753 bytes --]

On 2025-10-15 at 14:12:09, Ashlesh Gawande wrote:
> Oh I see - yeah don't want to erase the credentials.
> Was trying to figure why 403 was happening instead of a prompt (as I was not
> aware of netrc file being used).
> Thanks for the detailed explanation and suggestions Brian!
> 
> Is it worth it to include the netrc tests in git that I wrote as part of
> this

Yes, I think if you have patches to test our netrc handling, those would
be very welcome.  I was complaining a couple months ago about how we had
no tests for netrc after I accidentally broke the code that makes it
work, so I would very much appreciate any tests we could add to make
that less likely in the future.
-- 
brian m. carlson (they/them)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

  reply	other threads:[~2025-10-15 22:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-14 14:43 [PATCH] http.c: prompt for username on 403 Ashlesh Gawande
2025-10-14 21:29 ` brian m. carlson
2025-10-15 14:12   ` Ashlesh Gawande
2025-10-15 22:31     ` brian m. carlson [this message]
2025-12-09  8:22       ` Ashlesh Gawande
2025-12-10  2:05         ` brian m. carlson
2025-12-10 12:30           ` Ashlesh Gawande
2025-12-10 17:48             ` rsbecker
2025-12-10 22:28             ` brian m. carlson
2025-12-11  6:05               ` Ashlesh Gawande
2025-12-10 12:32           ` Ashlesh Gawande

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPAg3gYwzA9fHCC3@fruit.crustytoothpaste.net \
    --to=sandals@crustytoothpaste$(echo .)net \
    --cc=avarab@gmail$(echo .)com \
    --cc=git@ashlesh$(echo .)me \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=ps@pks$(echo .)im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox