From: "brian m. carlson" <sandals@crustytoothpaste•net>
To: Ashlesh Gawande <git@ashlesh•me>
Cc: git@vger•kernel.org, "Patrick Steinhardt" <ps@pks•im>,
"Junio C Hamano" <gitster@pobox•com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
Subject: Re: [PATCH] http.c: prompt for username on 403
Date: Wed, 10 Dec 2025 02:05:46 +0000 [thread overview]
Message-ID: <aTjVenutFBprwrrz@fruit.crustytoothpaste.net> (raw)
In-Reply-To: <79d2226c-b568-4385-a618-f0d3c06cd0a8@ashlesh.me>
[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]
On 2025-12-09 at 08:22:49, Ashlesh Gawande wrote:
> I was working on separating the tests and thought about the original
> proposal a bit more.
> To stop the credentials from being erased on 403 could something like the
> following be acceptable?
>
> else if (results->http_code == 401 || results->http_code == 403) {
> if ((http_auth.username && http_auth.password) ||\
> (http_auth.authtype && http_auth.credential)) {
> + // Do not override existing credentials on 403
> + if (results->http_code == 403) {
> + return HTTP_ERROR;
> + }
> +
> if (http_auth.multistage) {
>
> So then we would prompt on 403 only if credentials are not configured.
Can you tell me what file you see this in? I don't actually see any
place in the code that has "http_code == 403" in the latest version of
the main branch.
I wonder if your issue may already be fixed in a newer version than you
have.
--
brian m. carlson (they/them)
Toronto, Ontario, CA
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2025-12-10 2:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 14:43 [PATCH] http.c: prompt for username on 403 Ashlesh Gawande
2025-10-14 21:29 ` brian m. carlson
2025-10-15 14:12 ` Ashlesh Gawande
2025-10-15 22:31 ` brian m. carlson
2025-12-09 8:22 ` Ashlesh Gawande
2025-12-10 2:05 ` brian m. carlson [this message]
2025-12-10 12:30 ` Ashlesh Gawande
2025-12-10 17:48 ` rsbecker
2025-12-10 22:28 ` brian m. carlson
2025-12-11 6:05 ` Ashlesh Gawande
2025-12-10 12:32 ` Ashlesh Gawande
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTjVenutFBprwrrz@fruit.crustytoothpaste.net \
--to=sandals@crustytoothpaste$(echo .)net \
--cc=avarab@gmail$(echo .)com \
--cc=git@ashlesh$(echo .)me \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox