From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com>
To: "Toon Claes" <toon@iotcl•com>, git@vger•kernel.org
Cc: "Justin Tobler" <jltobler@gmail•com>,
"Siddharth Asthana" <siddharthasthana31@gmail•com>,
"Yee Cheng Chin" <yeecheng.chin@gmail•com>
Subject: Re: [PATCH 1/3] t3650: use option with value consistenly with equal sign
Date: Mon, 23 Mar 2026 20:17:56 +0100 [thread overview]
Message-ID: <ccc995f1-4da2-468a-97d6-f20993ca4b4c@app.fastmail.com> (raw)
In-Reply-To: <20260323-toon-replay-arbitrary-ref-v1-1-5c7172f675ec@iotcl.com>
On Mon, Mar 23, 2026, at 17:09, Toon Claes wrote:
> The tests in t3650-replay-basics have mixed use of option arguments
> with value with and without equal sign. Bring in consistency and use
> equal sign for all options that expect a value.
If it is about consistency, could you pick one or the other either way
or go with whatever happened to be most used right now?
Consistency by itself is a weaker argument than arguing that stuck form
is better for invoking git(1) commands, which is what gitcli(7) argues.
Which is to say: arguing for stuck form in the commit message based on
it being better is a stronger argument than wanting consistency. :)
Then once one form has been argued for or referenced it follows that you
should be consistent and use the best approach throughout.
> This makes it easier to distinguish them from positional arguments.
Maybe it’s just me, but sticking with the stuck form makes it harder to
mess up writing unintended options and positional arguments. Once
written it might be slightly more readable, but the main benefit is
using a style that makes messing up harder to pull off.
>
> Signed-off-by: Toon Claes <toon@iotcl•com>
> ---
> t/t3650-replay-basics.sh | 70 ++++++++++++++++++++++++------------------------
> 1 file changed, 35 insertions(+), 35 deletions(-)
>[snip]
next prev parent reply other threads:[~2026-03-23 19:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 16:09 [PATCH 0/3] Add option --ref to git-replay(1) Toon Claes
2026-03-23 16:09 ` [PATCH 1/3] t3650: use option with value consistenly with equal sign Toon Claes
2026-03-23 19:17 ` Kristoffer Haugsbakk [this message]
2026-03-23 20:06 ` Junio C Hamano
2026-03-25 12:43 ` Toon Claes
2026-03-23 16:09 ` [PATCH 2/3] builtin/replay: improve documentation on options Toon Claes
2026-03-23 16:09 ` [PATCH 3/3] replay: allow to specify a ref with option --ref Toon Claes
2026-03-23 18:01 ` Tian Yuchen
2026-03-25 12:50 ` Toon Claes
2026-03-23 19:07 ` Kristoffer Haugsbakk
2026-03-25 12:49 ` Toon Claes
2026-03-25 15:59 ` [PATCH v2 0/3] Add option --ref to git-replay(1) Toon Claes
2026-03-25 15:59 ` [PATCH v2 1/3] builtin/replay: mark options as not negatable Toon Claes
2026-03-25 15:59 ` [PATCH v2 2/3] replay: use stuck form in documentation and help message Toon Claes
2026-03-25 15:59 ` [PATCH v2 3/3] replay: allow to specify a ref with option --ref Toon Claes
2026-03-25 18:44 ` Junio C Hamano
2026-03-31 7:56 ` Toon Claes
2026-03-25 18:34 ` [PATCH v2 0/3] Add option --ref to git-replay(1) Junio C Hamano
2026-03-26 21:20 ` Junio C Hamano
2026-03-31 7:55 ` Toon Claes
2026-03-31 21:42 ` Junio C Hamano
2026-04-01 20:55 ` [PATCH v3 " Toon Claes
2026-04-01 20:55 ` [PATCH v3 1/3] builtin/replay: mark options as not negatable Toon Claes
2026-04-01 20:55 ` [PATCH v3 2/3] replay: use stuck form in documentation and help message Toon Claes
2026-04-01 20:55 ` [PATCH v3 3/3] replay: allow to specify a ref with option --ref Toon Claes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccc995f1-4da2-468a-97d6-f20993ca4b4c@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jltobler@gmail$(echo .)com \
--cc=siddharthasthana31@gmail$(echo .)com \
--cc=toon@iotcl$(echo .)com \
--cc=yeecheng.chin@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox