* [PATCH] convert: constify some variables in ident_to_worktree()
@ 2026-03-10 4:03 Collin Funk
0 siblings, 0 replies; only message in thread
From: Collin Funk @ 2026-03-10 4:03 UTC (permalink / raw)
To: git; +Cc: Collin Funk, Junio C Hamano
When building with glibc-2.43 there is the following warnings:
convert.c: In function ‘ident_to_worktree’:
convert.c:1189:24: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
1189 | dollar = memchr(src, '$', len);
| ^
convert.c:1212:32: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
1212 | dollar = memchr(src + 3, '$', len - 3);
| ^
convert.c:1223:29: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
1223 | spc = memchr(src + 4, ' ', dollar - src - 4);
| ^
The "dollar" and "space" pointers are used to iterate over the const
string "src". Since they are never written to we can make them const
too.
Signed-off-by: Collin Funk <collin.funk1@gmail•com>
---
convert.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/convert.c b/convert.c
index a34ec6ecdc..eae36c8a59 100644
--- a/convert.c
+++ b/convert.c
@@ -1168,7 +1168,8 @@ static int ident_to_worktree(const char *src, size_t len,
struct strbuf *buf, int ident)
{
struct object_id oid;
- char *to_free = NULL, *dollar, *spc;
+ char *to_free = NULL;
+ const char *dollar, *spc;
int cnt;
if (!ident)
--
2.53.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-03-10 4:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-10 4:03 [PATCH] convert: constify some variables in ident_to_worktree() Collin Funk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox