public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail•com>
To: git@vger•kernel.org
Subject: Re: [PATCH] [RFC] Introduce Git.pm
Date: Thu, 22 Jun 2006 10:07:58 +0200	[thread overview]
Message-ID: <e7dj4h$cv7$1@sea.gmane.org> (raw)
In-Reply-To: 20060622003546.17760.23089.stgit@machine.or.cz

Petr Baudis wrote:

> Most desirable now is proper error reporting, generic_in() for feeding
> input to Git commands and the repository() constructor doing some poking
> with git-rev-parse to get the git directory and subdirectory prefix.
> Those three are basically the prerequisities for converting git-mv.

I think that repository() constructor (to be converted in the 'new'
constructor I guess) should take 'binbin => "/usr/bin"' argument
optionally, to find where git binary is. 'libexecdir' can be also
supported, or one can get it from 'git --exec-path' and save.
 
> Currently Git.pm just wraps up exec()s of Git commands, but even that
> is not trivial to get right and various Git perl scripts do it in
> various inconsistent ways.

It would be nice to have also wrapers to reading files from git 
repository, ate least some generic read_file/readdir.

For example it might be faster to list branches and/or tags by directly
reading $GIT_DIR/refs directory than using 'git branch' or 'git tag -l'.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

  parent reply	other threads:[~2006-06-22  8:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-22  0:35 [PATCH] [RFC] Introduce Git.pm Petr Baudis
2006-06-22  1:03 ` Junio C Hamano
2006-06-22  7:18   ` Alex Riesen
2006-06-22 19:37   ` Petr Baudis
2006-06-22  2:31 ` Eric Wong
2006-06-22  8:07 ` Jakub Narebski [this message]
2006-06-22  9:01 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='e7dj4h$cv7$1@sea.gmane.org' \
    --to=jnareb@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox