public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail•com>
To: git@vger•kernel.org
Subject: Re: [PATCH] gitweb: Add support for grep searches
Date: Fri, 18 May 2007 13:58:28 +0200	[thread overview]
Message-ID: <f2k4d5$879$1@sea.gmane.org> (raw)
In-Reply-To: 20070517023112.21056.62390.stgit@rover

[Cc: Petr Baudis <pasky@suse•cz>, Junio C Hamano <junkio@cox•net>, 
 git@vger•kernel.org]

Petr Baudis wrote:

> The 'grep' type of search greps the currently selected tree for given
> regexp and shows the results in a fancy table with links into blob view.
> The number of shown matches is limited to 1000 and the whole feature
> can be turned off (grepping linux-2.6.git already makes repo.or.cz a bit
> unhappy).

Ack, FWIW.

By the way, I wonder if we should make search context (view) sensitive.
For example for 'history' view search would be limited to given pathspec,
grep search in a 'tree' view would search given tree only.

Additionally it would be nice to have links from search results page to
have search match highlighted, like search results on GitWiki.
-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

  parent reply	other threads:[~2007-05-18 11:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-17  2:31 [PATCH] gitweb: Add support for grep searches Petr Baudis
2007-05-17  9:00 ` Jakub Narebski
2007-05-18 11:58 ` Jakub Narebski [this message]
2007-05-18 12:35   ` Petr Baudis
2007-05-19  0:43     ` Jakub Narebski
  -- strict thread matches above, loose matches on Subject: below --
2007-04-27  3:41 Petr Baudis
2007-04-27  3:47 ` Petr Baudis
2007-04-27  3:59   ` Linus Torvalds
2007-04-27  4:21     ` Petr Baudis
2007-04-27  4:21     ` Petr Baudis
2007-04-27  4:34     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='f2k4d5$879$1@sea.gmane.org' \
    --to=jnareb@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox