public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Dirk Gouders <dirk@gouders•net>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org
Subject: Possible problem in --pretty=reference?
Date: Fri, 12 Dec 2025 14:25:22 +0100	[thread overview]
Message-ID: <ghfr9fbznh.fsf@gouders.net> (raw)

I just did a commit to code I am working on ([1] gives you a link to the
full repo) and noticed that --pretty=reference seems to not like my
commit message:

This is the output of `git log`:

------------------------------------------------------------------------
commit 93abaadcb0150e3555c91ff1f136cb029da87c0f (HEAD -> next)
Author: Dirk Gouders <dirk@gouders•net>
Date:   Fri Dec 12 13:54:36 2025 +0100

    line.normalized: fix a comment and a call of lsp_mdup2str() in the code

    When .normalized of lsp_line_t was given a null-terminator
    (ee7b96f (lsp_normalize: null-terminate returned data, 2025-12-03))
    a comment in lsp_line_t has been overseen.

    Fix this now.

    Further, at one location, .normalized is still copied with lsp_mdup2str()
    which isn't longer necessary.  That still works but doesn't show that we
    know, .normalized is null-terminated.

    Fix this by using lsp_mdup(), instead.

    Fixes: ee7b96f (lsp_normalize: null-terminate returned data, 2025-12-03)
    Signed-off-by: Dirk Gouders <dirk@gouders•net>
------------------------------------------------------------------------

And here is the output of `git log --pretty=reference`:

------------------------------------------------------------------------
93abaad (line.normalized: fix a comment and a call of lsp_mdup2str() in the code, 2025-12-12)
------------------------------------------------------------------------

All other commits look good with --pretty=reference...

Regards,

Dirk

[1] https://github.com/dgouders/lsp/tree/next

next             reply	other threads:[~2025-12-12 13:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-12 13:25 Dirk Gouders [this message]
2025-12-12 13:28 ` Possible problem in --pretty=reference? Dirk Gouders

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ghfr9fbznh.fsf@gouders.net \
    --to=dirk@gouders$(echo .)net \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox