public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org
Subject: Re: What's cooking in git.git (Nov 2009, #05; Sun, 22)
Date: Tue, 24 Nov 2009 02:53:48 -0800 (PST)	[thread overview]
Message-ID: <m3ljhwb3d6.fsf@localhost.localdomain> (raw)
In-Reply-To: <7vhbsl935q.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox•com> writes:

> * jn/gitweb-blame (2009-11-19) 6 commits.
>  - gitweb.js: fix null object exception in initials calculation
>  - gitweb: Minify gitweb.js if JSMIN is defined
>  - gitweb: Create links leading to 'blame_incremental' using JavaScript
>   (merged to 'next' on 2009-10-11 at 73c4a83)
>  + gitweb: Colorize 'blame_incremental' view during processing
>  + gitweb: Incremental blame (using JavaScript)
>  + gitweb: Add optional "time to generate page" info in footer
> 
> Ajax-y blame, with a few recent fixes.

Unfortunately current version does not work with IE8 (reported by
Stephen Boyd); it stops at the very beginning of JavaScript blaming
with the two JavaScript errors:

- "firstChild is null or not an object", caused by the fact that
  '<a href=""> </a>' element doesn't have firstChild which is text
  node with space as contents in DOM.  This can be easily worked
  around.

- "Unspecified error" (twice (sic!) for the same line), which
  I have currently no idea how to fix; it points to the following
  line:

       if (xhr.readyState === 3 && xhr.status !== 200) {

> * pb/gitweb-no-project-list (2009-11-06) 3 commits.
>  . gitweb: Polish the content tags support
>  . gitweb: Support for no project list on gitweb front page
>  . gitweb: Refactor project list routines
> 
> I picked these up but didn't queue as Warthog9's comments made certain
> amount of sense to me.

I'd like to see at least refactoring project list subroutine:
currently printing list of projects is entangled with filtering
said list; IMHO filtering list of projects should be done upfront.

-- 
Jakub Narebski
Poland
ShadeHawk on #git

      parent reply	other threads:[~2009-11-24 10:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-23  6:16 What's cooking in git.git (Nov 2009, #05; Sun, 22) Junio C Hamano
2009-11-23  6:24 ` Sverre Rabbelier
2009-11-23  9:59 ` Johan Herland
2009-11-24 10:53 ` Jakub Narebski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ljhwb3d6.fsf@localhost.localdomain \
    --to=jnareb@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox