From: Jakub Narebski <jnareb@gmail•com>
To: Junio C Hamano <gitster@pobox•com>, Sebastien Cevey <seb@cine7•net>
Cc: git@vger•kernel.org
Subject: Re: What's cooking in git.git (Feb 2009, #04; Sun, 15)
Date: Sun, 15 Feb 2009 03:12:17 -0800 (PST) [thread overview]
Message-ID: <m3ocx4t0mv.fsf@localhost.localdomain> (raw)
In-Reply-To: <7v1vu0nfu4.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox•com> writes:
> * sc/gitweb-category (Fri Dec 12 00:45:12 2008 +0100) 3 commits
> - gitweb: Optional grouping of projects by category
> - gitweb: Split git_project_list_body in two functions
> - gitweb: Modularized git_get_project_description to be more generic
>
> Design discussion between Jakub and Sebastien seems to have stalled.
I have changed signature of new git_get_file_or_project_config in
first patch in series from $variable_name, $repo_path to reverse
order, i.e. $repo_path, $variable_name to make it easier to extend it
further in the future if needed (for example have config variable name
be different from name of file in $GIT_DIR). BTW. commit message
should mention what for this refactoring is preparing.
But I am bit stalled at second patch in the series, which extract
_printing_ the rows in separate function... while it should IMHO also
refactor _filtering_ projects list, and not have "filtering as we
print" current code uses... which would be night incompatibile with
dividing projects list into pages.
I think this patch series is definitely for after 1.6.2
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2009-02-15 11:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-15 10:40 What's cooking in git.git (Feb 2009, #04; Sun, 15) Junio C Hamano
2009-02-15 11:12 ` Jakub Narebski [this message]
2009-02-16 15:27 ` Sebastien Cevey
2009-02-16 16:44 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ocx4t0mv.fsf@localhost.localdomain \
--to=jnareb@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=seb@cine7$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox