From: "Phillip Wood via GitGitGadget" <gitgitgadget@gmail•com>
To: git@vger•kernel.org
Cc: Han Jiang <jhcarl0814@gmail•com>,
Phillip Wood <phillip.wood@dunelm•org.uk>
Subject: [PATCH 0/4] remote: branch setting fixes
Date: Wed, 11 Sep 2024 15:18:33 +0000 [thread overview]
Message-ID: <pull.1789.git.1726067917.gitgitgadget@gmail.com> (raw)
This series fixes some rough edges when setting remote tracking branches
with "git remote set-branches" or "git remote add -t". Han Jiang reported
that if there is no fetch refspec set for a remote then "git remote
set-branches" silently fails. While investigating that I noticed that the
code does not check that the branch names are syntactically valid refnames
and so can create invalid refspecs. This series fixes both issues.
Phillip Wood (4):
remote: fix set-branches when no branches are set
remote: print an error if refspec cannot be removed
remote add: use strvec to store tracking branches
remote: check branch names
builtin/remote.c | 41 ++++++++++++++++++++++++++++++++---------
t/t5505-remote.sh | 42 +++++++++++++++++++++++++++++++++++++++---
2 files changed, 71 insertions(+), 12 deletions(-)
base-commit: 4590f2e9412378c61eac95966709c78766d326ba
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1789%2Fphillipwood%2Fremote-set-branches-missing-fetch-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1789/phillipwood/remote-set-branches-missing-fetch-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1789
--
gitgitgadget
next reply other threads:[~2024-09-11 15:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 15:18 Phillip Wood via GitGitGadget [this message]
2024-09-11 15:18 ` [PATCH 1/4] remote: fix set-branches when no branches are set Phillip Wood via GitGitGadget
2024-09-11 20:45 ` Junio C Hamano
2024-09-12 10:04 ` Patrick Steinhardt
2024-09-11 15:18 ` [PATCH 2/4] remote: print an error if refspec cannot be removed Phillip Wood via GitGitGadget
2024-09-11 20:52 ` Junio C Hamano
2024-09-12 10:04 ` Patrick Steinhardt
2024-09-12 16:22 ` Junio C Hamano
2024-09-13 3:08 ` Patrick Steinhardt
2024-09-13 15:11 ` phillip.wood123
2024-09-13 17:38 ` Junio C Hamano
2024-09-11 15:18 ` [PATCH 3/4] remote add: use strvec to store tracking branches Phillip Wood via GitGitGadget
2024-09-11 17:05 ` Junio C Hamano
2024-09-12 10:05 ` Patrick Steinhardt
2024-09-11 15:18 ` [PATCH 4/4] remote: check branch names Phillip Wood via GitGitGadget
2024-09-11 17:03 ` Junio C Hamano
2024-09-12 10:05 ` Patrick Steinhardt
2024-09-12 16:32 ` Junio C Hamano
2024-09-13 15:09 ` phillip.wood123
2024-09-13 17:49 ` Junio C Hamano
2024-09-18 13:18 ` phillip.wood123
2024-09-18 20:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1789.git.1726067917.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jhcarl0814@gmail$(echo .)com \
--cc=phillip.wood@dunelm$(echo .)org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox