From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Tanay Abhra <tanayabh@gmail•com>
Cc: git@vger•kernel.org, Ramkumar Ramachandra <artagnon@gmail•com>
Subject: Re: [PATCH/RFC v2 1/2] git_default_config() rewritten using the config-set API
Date: Wed, 13 Aug 2014 18:00:47 +0200 [thread overview]
Message-ID: <vpq1tsks7kg.fsf@anie.imag.fr> (raw)
In-Reply-To: <53EB6914.2030807@gmail.com> (Tanay Abhra's message of "Wed, 13 Aug 2014 19:03:08 +0530")
Tanay Abhra <tanayabh@gmail•com> writes:
> git_default_config() now uses config-set API functions to query for
> values.
I believe you missed a few spots:
$ git grep -n 'git_default_config[^(]'
Documentation/user-manual.txt:4287: git_config(git_default_config);
archive.c:416: git_config(git_default_config, NULL);
builtin/config.c:577: git_config(git_default_config, NULL);
color.h:73: * if you are just going to change to git_default_config, too.
fetch-pack.c:880: git_config(git_default_config, NULL);
http.c:393: config.cascade_fn = git_default_config;
rerere.c:580: git_config(git_default_config, NULL);
rerere.c:710: git_config(git_default_config, NULL);
The following ones should probably be rewritten too:
archive.c:416: git_config(git_default_config, NULL);
builtin/config.c:577: git_config(git_default_config, NULL);
fetch-pack.c:880: git_config(git_default_config, NULL);
rerere.c:580: git_config(git_default_config, NULL);
rerere.c:710: git_config(git_default_config, NULL);
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2014-08-13 16:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 8:21 [PATCH 1/4] fast-import.c: replace `git_config()` with `git_config_get_*()` family Tanay Abhra
2014-08-13 8:22 ` [PATCH 2/4] ll-merge.c: refactor `read_merge_config()` to use `git_config_string()` Tanay Abhra
2014-08-13 11:32 ` Matthieu Moy
2014-08-13 12:43 ` [PATCH v2 " Tanay Abhra
2014-08-13 13:07 ` Matthieu Moy
2014-08-13 17:07 ` Junio C Hamano
2014-08-13 8:22 ` [PATCH 3/4] merge-recursive.c: replace `git_config()` with `git_config_get_int()` Tanay Abhra
2014-08-13 11:34 ` Matthieu Moy
2014-08-13 8:22 ` [PATCH 4/4] builtin/apply.c: replace `git_config()` with `git_config_get_string_const()` Tanay Abhra
2014-08-13 11:24 ` [PATCH 1/4] fast-import.c: replace `git_config()` with `git_config_get_*()` family Matthieu Moy
2014-08-13 12:11 ` Tanay Abhra
2014-08-13 12:22 ` [PATCH v2 1/5] " Tanay Abhra
2014-08-13 13:10 ` Matthieu Moy
2014-08-13 13:33 ` [PATCH/RFC v2 1/2] git_default_config() rewritten using the config-set API Tanay Abhra
2014-08-13 13:39 ` [PATCH/RFC v2 2/2] use the new git_default_config() Tanay Abhra
2014-08-13 16:00 ` Matthieu Moy [this message]
2014-08-13 17:18 ` [PATCH/RFC v2 1/2] git_default_config() rewritten using the config-set API Junio C Hamano
2014-08-13 16:16 ` Matthieu Moy
2014-08-13 17:14 ` [PATCH 1/4] fast-import.c: replace `git_config()` with `git_config_get_*()` family Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq1tsks7kg.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=artagnon@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=tanayabh@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox