From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Karthik Nayak <karthik.188@gmail•com>
Cc: git@vger•kernel.org, christian.couder@gmail•com
Subject: Re: [PATCH/WIP v3 4/4] ref-filter: move code from 'for-each-ref'
Date: Thu, 28 May 2015 22:35:00 +0200 [thread overview]
Message-ID: <vpq382go2yz.fsf@anie.imag.fr> (raw)
In-Reply-To: <1432835025-13291-4-git-send-email-karthik.188@gmail.com> (Karthik Nayak's message of "Thu, 28 May 2015 23:13:45 +0530")
Karthik Nayak <karthik.188@gmail•com> writes:
> Move most of the code from 'for-each-ref' to 'ref-filter' to make
> it publically available to other commands, this is to unify the code
s/publically/publicly/
> --- /dev/null
> +++ b/ref-filter.h
Moving file to the .h file should be done in a separate patch. I don't
want to review the 1050 lines of cut-and-paste other than by doing the
cut-and-paste myself and see if I get the same result, but this part is
not as straightforward and needs proper thinking and review.
In short: the big code movement should be *only* a cut-and-paste, alone
in its own patch.
On overall, we're getting close to an acceptable version for these 4
patches. My advice: prioritize polishing these few patches, so that we
can do a detailed review and then consider this part "done" (either
merged in git.git or not, but I'd like to avoid having to review the
code movement & refactoring again when we move to the next patches).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-05-28 20:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 17:38 [PATCH/WIP v3 1/4] for-each-ref: re-structure code for moving to 'ref-filter' Karthik Nayak
2015-05-28 17:43 ` [PATCH/WIP v3 1/4] for-each-ref: extract helper functions out of grab_single_ref() Karthik Nayak
2015-05-28 20:13 ` Matthieu Moy
2015-05-28 20:33 ` Karthik Nayak
2015-05-28 17:43 ` [PATCH/WIP v3 2/4] for-each-ref: introduce new structures for better organisation Karthik Nayak
2015-05-28 20:26 ` Matthieu Moy
2015-05-28 20:37 ` Karthik Nayak
2015-05-28 20:41 ` Matthieu Moy
2015-05-28 20:43 ` Karthik Nayak
2015-05-28 21:18 ` Junio C Hamano
2015-05-28 21:28 ` Junio C Hamano
2015-05-28 17:43 ` [PATCH/WIP v3 3/4] for-each-ref: rename some functions and make them public Karthik Nayak
2015-05-28 17:43 ` [PATCH/WIP v3 4/4] ref-filter: move code from 'for-each-ref' Karthik Nayak
2015-05-28 20:35 ` Matthieu Moy [this message]
2015-05-28 20:46 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq382go2yz.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=karthik.188@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox