public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Pascal Obry <pascal@obry•net>
Cc: Git Mailing List <git@vger•kernel.org>
Subject: Re: [PATCH v3] Do not decode url protocol.
Date: Tue, 22 Jun 2010 18:08:52 +0200	[thread overview]
Message-ID: <vpq39wf82y3.fsf@bauges.imag.fr> (raw)
In-Reply-To: <AANLkTik2M4Wxa-C6iRf7ShlcrwXu1ALNXtKwbA-mO5ge@mail.gmail.com> (Pascal Obry's message of "Tue\, 22 Jun 2010 13\:58\:17 +0200")

Pascal Obry <pascal@obry•net> writes:

> -- 
> 1.7.1.524.g6df2f
>
> Ok, given Matthieu comments here is another version of the patch which
> should apply cleanly
> and won't clobber log message with my comments!

Thanks for making the life of our maintainer easier :-).

Unfortunately, it's still not the right place for comments ;-). That's
OK with Git AFAICT, but readers expect them between the --- (tripple)
and the diffstat.

Unless I missed something, this version doesn't address my earlier
comment:

Matthieu Moy <Matthieu.Moy@grenoble-inp•fr> writes:

> Pascal Obry <pascal@obry•net> writes:
>
>> @@ -70,9 +70,18 @@ static int url_decode_char(const char *q)
>>  static char *url_decode_internal(const char **query, const char *stop_at)
>>  {
>
> This function is called from multiple places :

[...]

> I don't think you want to avoid escaping until the first slash in
> url_decode_parameter_name and url_decode_parameter_value. I think you
> want to patch url_decode, not url_decode_internal.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

next prev parent reply	other threads:[~2010-06-22 16:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-22 11:58 [PATCH v3] Do not decode url protocol Pascal Obry
2010-06-22 16:08 ` Matthieu Moy [this message]
2010-06-22 16:47   ` Pascal Obry
2010-06-22 17:08     ` Matthieu Moy
2010-06-22 17:22       ` Pascal Obry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vpq39wf82y3.fsf@bauges.imag.fr \
    --to=matthieu.moy@grenoble-inp$(echo .)fr \
    --cc=git@vger$(echo .)kernel.org \
    --cc=pascal@obry$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox