From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: pascal@obry•net
Cc: Git Mailing List <git@vger•kernel.org>
Subject: Re: [PATCH v3] Do not decode url protocol.
Date: Tue, 22 Jun 2010 19:08:31 +0200 [thread overview]
Message-ID: <vpqfx0fxaeo.fsf@bauges.imag.fr> (raw)
In-Reply-To: <4C20E92B.1030405@obry.net> (Pascal Obry's message of "Tue\, 22 Jun 2010 18\:47\:39 +0200")
Pascal Obry <pascal.obry@gmail•com> writes:
> Matthieu,
>
>> Unless I missed something, this version doesn't address my earlier
>> comment:
>
> Because I do not agree.
I'm fine with disagreeing, but then you should argue. This would allow
either Junio to be convinced, or me to argue back.
> The three procedures:
>
> char *url_decode(const char *url)
> char *url_decode_parameter_name(const char **query)
> char *url_decode_parameter_value(const char **query)
>
> are all passed a full url (with protocol).
The caller is this (http-backend.c):
static struct string_list *get_parameters(void)
{
[...]
while (query && *query) {
char *name = url_decode_parameter_name(&query);
char *value = url_decode_parameter_value(&query);
[...]
}
which advances "query" as the URL is decoded, hence passing query as a
pointer to the argument being parsed, not to the full URL.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2010-06-22 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 11:58 [PATCH v3] Do not decode url protocol Pascal Obry
2010-06-22 16:08 ` Matthieu Moy
2010-06-22 16:47 ` Pascal Obry
2010-06-22 17:08 ` Matthieu Moy [this message]
2010-06-22 17:22 ` Pascal Obry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqfx0fxaeo.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=pascal@obry$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox