From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Junio C Hamano <gitster@pobox•com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>,
"Marc Branchaud" <marcnarc@xiplink•com>,
git@vger•kernel.org
Subject: Re: [RFC/PATCH] rebase -i: add run command to launch a shell command
Date: Tue, 03 Aug 2010 08:37:02 +0200 [thread overview]
Message-ID: <vpq4ofcb3sh.fsf@bauges.imag.fr> (raw)
In-Reply-To: <7vwrs8k978.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Mon\, 02 Aug 2010 14\:15\:23 -0700")
Junio C Hamano <gitster@pobox•com> writes:
> Matthieu Moy <Matthieu.Moy@grenoble-inp•fr> writes:
>
>> That's a good question. My original patch was running the command from
>> the toplevel, which is the natural way to implement it. I've changed
>> my mind to execute the command from the place where "git rebase -i"
>> was started (which means this has to be memorized in a temporary file
>> to be persistant accross "git rebase --continue"). I think this makes
>> more sense for the user, and I've actually already been biten by the
>> old behavior, running "rebase -i" from a doc/ subdirectory, and
>> wondering why my "exec make" was rebuilding the code itself.
>>
>> This comes with at least one drawback: if directory from which the
>> rebase was started didn't exist in the past, then we can't do a simple
>> "cd" to it. My implementation re-creates the directory temporarily, so
>> that the command can run, and cleans it up afterwards. The only really
>> problematic case is when the directory can not be created (like
>> directory/file conflict). It this case, the command is not ran, and
>> the script exits.
>
> Sorry to join the discussion after you have already coded it, but I don't
> think running the external command at a random subdirectory that the
> operation happened to have started makes much sense, as rebase is a
> tree-wide operation. The user if s/he so chooses can chdir down (if the
> directory still exists in the revision in question) in the script, but I
> think the built-in behaviour should be to just run it from the toplevel.
I'm waiting for other people's opinion, since I'm still not 100%
convinced, but this seems to reflect the majority's opinion.
And the simplicity of the code also is an argument: even if the "I'm
too lazy to code it" is not applicable anymore, the simplest version
will also be the simplest to maintain.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2010-08-03 6:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 13:29 [RFC/PATCH] rebase -i: add run command to launch a shell command Matthieu Moy
2010-07-28 14:12 ` Santi Béjar
2010-07-28 14:26 ` Matthieu Moy
2010-07-30 10:04 ` Matthieu Moy
2010-07-30 14:51 ` Marc Branchaud
2010-07-30 15:24 ` Matthieu Moy
2010-07-30 18:26 ` Neal Kreitzinger
2010-07-31 13:27 ` Matthieu Moy
2010-07-31 13:56 ` Ævar Arnfjörð Bjarmason
2010-07-31 14:25 ` Miles Bader
2010-08-02 10:02 ` Matthieu Moy
2010-08-02 10:03 ` [PATCH] rebase -i: add exec " Matthieu Moy
2010-08-02 12:30 ` Jared Hance
2010-08-02 15:51 ` Ævar Arnfjörð Bjarmason
2010-08-06 21:07 ` Johannes Sixt
2010-08-07 8:48 ` Matthieu Moy
2010-08-07 8:56 ` [PATCH 1/2 (new version)] " Matthieu Moy
2010-08-07 8:56 ` [PATCH 2/2] test-lib: user-friendly alternatives to test [!] [-d|-f] Matthieu Moy
2010-08-02 15:04 ` [RFC/PATCH] rebase -i: add run command to launch a shell command Paolo Bonzini
2010-08-02 21:15 ` Junio C Hamano
2010-08-03 6:37 ` Matthieu Moy [this message]
2010-08-03 8:47 ` Kris Shannon
2010-08-03 9:16 ` Matthieu Moy
2010-07-31 15:28 ` Paolo Bonzini
2010-07-31 15:52 ` Ævar Arnfjörð Bjarmason
2010-07-31 18:54 ` Jared Hance
2010-07-31 14:40 ` Jared Hance
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq4ofcb3sh.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=avarab@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=marcnarc@xiplink$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox