From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Johannes Sixt <j6t@kdbg•org>
Cc: git@vger•kernel.org, gitster@pobox•com,
"Ævar Arnfjörð Bjarmason" <avarab@gmail•com>,
"Marc Branchaud" <marcnarc@xiplink•com>
Subject: Re: [PATCH] rebase -i: add exec command to launch a shell command
Date: Sat, 07 Aug 2010 10:48:36 +0200 [thread overview]
Message-ID: <vpqeiealsez.fsf@bauges.imag.fr> (raw)
In-Reply-To: <201008062307.54841.j6t@kdbg.org> (Johannes Sixt's message of "Fri\, 6 Aug 2010 23\:07\:54 +0200")
Johannes Sixt <j6t@kdbg•org> writes:
> On Montag, 2. August 2010, Matthieu Moy wrote:
>> The typical usage pattern would be to run a test (or simply a compilation
>> command) at given points in history.
>
> What happens if the command modifies the worktree and/or the index?
Something terrible :-(. The next patch application fails, and the
patch is more or less silently dropped (I thought it would fail giving
the user an opportunity to fix and re-apply, but it doesn't).
New version checks working tree cleanness right after the command
finishes, and stops cleanly, in time (restart with "git rebase
--continue"). This comes with a new test.
(But the command can possibly create a new commit or amend the
previous one without problem)
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2010-08-07 12:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 13:29 [RFC/PATCH] rebase -i: add run command to launch a shell command Matthieu Moy
2010-07-28 14:12 ` Santi Béjar
2010-07-28 14:26 ` Matthieu Moy
2010-07-30 10:04 ` Matthieu Moy
2010-07-30 14:51 ` Marc Branchaud
2010-07-30 15:24 ` Matthieu Moy
2010-07-30 18:26 ` Neal Kreitzinger
2010-07-31 13:27 ` Matthieu Moy
2010-07-31 13:56 ` Ævar Arnfjörð Bjarmason
2010-07-31 14:25 ` Miles Bader
2010-08-02 10:02 ` Matthieu Moy
2010-08-02 10:03 ` [PATCH] rebase -i: add exec " Matthieu Moy
2010-08-02 12:30 ` Jared Hance
2010-08-02 15:51 ` Ævar Arnfjörð Bjarmason
2010-08-06 21:07 ` Johannes Sixt
2010-08-07 8:48 ` Matthieu Moy [this message]
2010-08-07 8:56 ` [PATCH 1/2 (new version)] " Matthieu Moy
2010-08-07 8:56 ` [PATCH 2/2] test-lib: user-friendly alternatives to test [!] [-d|-f] Matthieu Moy
2010-08-02 15:04 ` [RFC/PATCH] rebase -i: add run command to launch a shell command Paolo Bonzini
2010-08-02 21:15 ` Junio C Hamano
2010-08-03 6:37 ` Matthieu Moy
2010-08-03 8:47 ` Kris Shannon
2010-08-03 9:16 ` Matthieu Moy
2010-07-31 15:28 ` Paolo Bonzini
2010-07-31 15:52 ` Ævar Arnfjörð Bjarmason
2010-07-31 18:54 ` Jared Hance
2010-07-31 14:40 ` Jared Hance
-- strict thread matches above, loose matches on Subject: below --
2010-08-05 13:00 [PATCH] rebase -i: add exec " Matthieu Moy
2010-08-05 13:31 ` Ævar Arnfjörð Bjarmason
2010-08-05 16:47 ` Matthieu Moy
2010-08-05 18:24 ` Erik Faye-Lund
2010-08-05 18:37 ` Jacob Helwig
2010-08-05 20:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqeiealsez.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=avarab@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=j6t@kdbg$(echo .)org \
--cc=marcnarc@xiplink$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox