From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: "Guillaume Pagès" <guillaume.pages@ensimag•grenoble-inp.fr>
Cc: git@vger•kernel.org,
Remi Galan <remi.galan-alfonso@ensimag•grenoble-inp.fr>,
Remi Lespinet <remi.lespinet@ensimag•grenoble-inp.fr>,
Louis-Alexandre Stuber
<louis--alexandre.stuber@ensimag•grenoble-inp.fr>,
Antoine Delaite <antoine.delaite@ensimag•grenoble-inp.fr>
Subject: Re: [PATCH 4/4] status: add new tests for status during rebase -i
Date: Thu, 04 Jun 2015 10:11:25 +0200 [thread overview]
Message-ID: <vpq6173zydu.fsf@anie.imag.fr> (raw)
In-Reply-To: <1433368825-24617-4-git-send-email-guillaume.pages@ensimag.grenoble-inp.fr> ("Guillaume \=\?iso-8859-1\?Q\?Pag\=E8s\=22's\?\= message of "Thu, 4 Jun 2015 00:00:25 +0200")
I'd swap 3/4 and 4/4 so that we see the impact of your code on these new
tests. I won't insist on that though.
Please help reviewers by explaining in the commit message why these
tests are needed (what was not covered properly by existing tests?)
Guillaume Pagès <guillaume.pages@ensimag•grenoble-inp.fr> writes:
> +test_expect_success 'status: two commands done, two remainings' '
> + FAKE_LINES="1 exec_exit_15 2 3" &&
> + export FAKE_LINES &&
> + test_when_finished "git rebase --abort" &&
> + ONTO=$(git rev-parse --short HEAD~3) &&
> + COMMIT4=$(git rev-parse HEAD) &&
> + COMMIT3=$(git rev-parse HEAD^) &&
> + COMMIT2=$(git rev-parse HEAD^^) &&
> + (git rebase -i HEAD~3 || true)&&
Space before &&
(same on second test)
> + cat >expected <<EOF &&
Indent with spaces.
I did not do a thourough review, but this version looks much, much nicer
than the previous one (see how PATCH 1/4 and PATCH 2/4 are nice now?).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-06-04 8:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 22:00 [PATCH 1/4] status: factor two rebase-related messages together Guillaume Pagès
2015-06-03 22:00 ` [PATCH 2/4] status: differentiate interactive from non-interactive rebases Guillaume Pagès
2015-06-03 22:00 ` [PATCH 3/4] status: give more information during rebase -i Guillaume Pagès
2015-06-04 8:06 ` Matthieu Moy
2015-06-04 17:19 ` Junio C Hamano
2015-06-05 16:35 ` Guillaume Pages
2015-06-05 17:11 ` Junio C Hamano
2015-06-03 22:00 ` [PATCH 4/4] status: add new tests for status " Guillaume Pagès
2015-06-04 8:11 ` Matthieu Moy [this message]
2015-06-08 22:00 ` [PATCH 1/4] status: factor two rebase-related messages together Junio C Hamano
2015-06-09 7:33 ` Guillaume Pages
-- strict thread matches above, loose matches on Subject: below --
2015-06-08 14:55 [PATCH 3/4] status: give more information during rebase -i Guillaume Pagès
2015-06-08 14:55 ` [PATCH 4/4] status: add new tests for status " Guillaume Pagès
2015-06-09 14:42 [PATCH 1/4] status: factor two rebase-related messages together Guillaume Pagès
2015-06-09 14:42 ` [PATCH 4/4] status: add new tests for status during rebase -i Guillaume Pagès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq6173zydu.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=antoine.delaite@ensimag$(echo .)grenoble-inp.fr \
--cc=git@vger$(echo .)kernel.org \
--cc=guillaume.pages@ensimag$(echo .)grenoble-inp.fr \
--cc=louis--alexandre.stuber@ensimag$(echo .)grenoble-inp.fr \
--cc=remi.galan-alfonso@ensimag$(echo .)grenoble-inp.fr \
--cc=remi.lespinet@ensimag$(echo .)grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox