From: Junio C Hamano <gitster@pobox•com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
Cc: "Guillaume Pagès" <guillaume.pages@ensimag•grenoble-inp.fr>,
git@vger•kernel.org,
"Remi Galan" <remi.galan-alfonso@ensimag•grenoble-inp.fr>,
"Remi Lespinet" <remi.lespinet@ensimag•grenoble-inp.fr>,
"Louis-Alexandre Stuber"
<louis--alexandre.stuber@ensimag•grenoble-inp.fr>,
"Antoine Delaite" <antoine.delaite@ensimag•grenoble-inp.fr>
Subject: Re: [PATCH 3/4] status: give more information during rebase -i
Date: Thu, 04 Jun 2015 10:19:00 -0700 [thread overview]
Message-ID: <xmqqtwunv1bv.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <vpqfv67zylq.fsf@anie.imag.fr> (Matthieu Moy's message of "Thu, 04 Jun 2015 10:06:41 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp•fr> writes:
>> +void get_two_last_lines(char *filename, int *numlines, char **lines)
>> +{
>> +...
>> +}
>> +
>> +void get_two_first_lines(char *filename, int *numlines, char **lines)
>> +{
>> +...
>> +}
I had a handful of comments on these:
- Do we need two separate and overly specific functions like these,
i.e. "two" and "first/last"?
- Wouldn't people want to be able to configure the number of lines?
- Do we really want get_two_{first,last}_LINES() functions?
I am wondering if insn sheets these functions read include
comments, in which case get_n_{first,last}_commands() may be a
more correct name.
- Wouldn't it be necessary for these functions to report the total
number of commands, instead of giving "void" back? Otherwise how
would the caller produce summary like this:
An interactive rebase of 14 commits in progress. You have
replayed 4 commits so far, the last few of which were:
da66b27 remote.c: provide per-branch pushremote name
f052154 remote.c: hoist branch.*.remote lookup out of
and 10 more commits to go, the next few of which are:
a9f9f8c remote.c: introduce branch_get_upstream helper
8770e6f remote.c: hoist read_config into remote_get_1
Note that I am not suggesting the phrasing or presentation. The
information content is what I am interested in.
next prev parent reply other threads:[~2015-06-04 17:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 22:00 [PATCH 1/4] status: factor two rebase-related messages together Guillaume Pagès
2015-06-03 22:00 ` [PATCH 2/4] status: differentiate interactive from non-interactive rebases Guillaume Pagès
2015-06-03 22:00 ` [PATCH 3/4] status: give more information during rebase -i Guillaume Pagès
2015-06-04 8:06 ` Matthieu Moy
2015-06-04 17:19 ` Junio C Hamano [this message]
2015-06-05 16:35 ` Guillaume Pages
2015-06-05 17:11 ` Junio C Hamano
2015-06-03 22:00 ` [PATCH 4/4] status: add new tests for status " Guillaume Pagès
2015-06-04 8:11 ` Matthieu Moy
2015-06-08 22:00 ` [PATCH 1/4] status: factor two rebase-related messages together Junio C Hamano
2015-06-09 7:33 ` Guillaume Pages
-- strict thread matches above, loose matches on Subject: below --
2015-06-08 14:55 [PATCH 3/4] status: give more information during rebase -i Guillaume Pagès
2015-06-08 16:17 ` Matthieu Moy
2015-06-08 22:11 ` Junio C Hamano
2015-06-09 8:57 ` Guillaume Pages
2015-06-09 14:42 [PATCH 1/4] status: factor two rebase-related messages together Guillaume Pagès
2015-06-09 14:42 ` [PATCH 3/4] status: give more information during rebase -i Guillaume Pagès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtwunv1bv.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=antoine.delaite@ensimag$(echo .)grenoble-inp.fr \
--cc=git@vger$(echo .)kernel.org \
--cc=guillaume.pages@ensimag$(echo .)grenoble-inp.fr \
--cc=louis--alexandre.stuber@ensimag$(echo .)grenoble-inp.fr \
--cc=remi.galan-alfonso@ensimag$(echo .)grenoble-inp.fr \
--cc=remi.lespinet@ensimag$(echo .)grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox