From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Karthik Nayak <karthik.188@gmail•com>
Cc: git@vger•kernel.org, christian.couder@gmail•com
Subject: Re: [PATCH v3 8/9] tag.c: implement '--format' option
Date: Wed, 22 Jul 2015 21:38:34 +0200 [thread overview]
Message-ID: <vpq7fpsnft1.fsf@anie.imag.fr> (raw)
In-Reply-To: <1437256837-13378-2-git-send-email-Karthik.188@gmail.com> (Karthik Nayak's message of "Sun, 19 Jul 2015 03:30:36 +0530")
Karthik Nayak <karthik.188@gmail•com> writes:
> --- a/Documentation/git-tag.txt
> +++ b/Documentation/git-tag.txt
> @@ -13,7 +13,8 @@ SYNOPSIS
> <tagname> [<commit> | <object>]
> 'git tag' -d <tagname>...
> 'git tag' [-n[<num>]] -l [--contains <commit>] [--points-at <object>]
> - [--column[=<options>] | --no-column] [--sort=<key>] [<pattern>...]
> + [--column[=<options>] | --no-column] [--sort=<key>] [--format=<format>]
> + [<pattern>...]
> 'git tag' -v <tagname>...
>
> DESCRIPTION
> @@ -155,6 +156,19 @@ This option is only applicable when listing tags without annotation lines.
> The object that the new tag will refer to, usually a commit.
> Defaults to HEAD.
>
> +<format>::
> + A string that interpolates `%(fieldname)` from the
> + object pointed at by a ref being shown. If `fieldname`
> + is prefixed with an asterisk (`*`) and the ref points
> + at a tag object, the value for the field in the object
> + tag refers is used. When unspecified, defaults to
> + `%(objectname) SPC %(objecttype) TAB %(refname)`.
I think this last sentence is taken from for-each-ref where it is true,
but for 'git tag', the default is just %(refname:short), as written
here:
> - else
> + else if (!format)
> format = "%(refname:short)";
right?
> --- a/t/t7004-tag.sh
> +++ b/t/t7004-tag.sh
> @@ -1507,4 +1507,20 @@ EOF"
> test_cmp expect actual
> '
>
> +test_expect_success '--format cannot be used with -n' '
> + test_must_fail git tag -l -n4 --format="%(refname)"
> +'
> +
> +test_expect_success '--format should list tags as per format given' '
> + cat >expect <<-\EOF &&
> + foo1.10
> + foo1.3
> + foo1.6
> + foo1.6-rc1
> + foo1.6-rc2
> + EOF
> + git tag -l --format="%(refname)" "foo*" >actual &&
> + test_cmp expect actual
> +'
This tests the pattern argument, but the the test still passes if I
remove the --format option, so it does not test what it claims.
Also, why does "git tag"'s %(refname) behave like "git for-each-ref"'s
%(refname:short)? I find it very confusing as I think --format's
argument should be interpreted the same way for all ref-listing
commands. Actually I didn't find a way to have "git tag" display the
full refname other than with --format "refs/tags/%(refname)".
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-07-22 19:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-18 19:12 [PATCH v3 0/9] Port tag.c to use ref-filter APIs Karthik Nayak
2015-07-18 19:12 ` [PATCH v3 1/9] ref-filter: add option to align atoms to the left Karthik Nayak
2015-07-19 23:49 ` Eric Sunshine
2015-07-20 15:06 ` Karthik Nayak
2015-07-20 16:12 ` Junio C Hamano
2015-07-20 17:47 ` Eric Sunshine
2015-07-20 16:37 ` Junio C Hamano
2015-07-20 17:04 ` Karthik Nayak
2015-07-20 17:22 ` Karthik Nayak
2015-07-20 18:01 ` Eric Sunshine
2015-07-20 18:23 ` Karthik Nayak
2015-07-20 17:29 ` Junio C Hamano
2015-07-21 18:00 ` Karthik Nayak
2015-07-22 18:44 ` Matthieu Moy
2015-07-23 14:32 ` Karthik Nayak
2015-07-18 19:12 ` [PATCH v3 2/9] ref-filter: add option to filter only tags Karthik Nayak
2015-07-18 19:12 ` [PATCH v3 3/9] ref-filter: support printing N lines from tag annotation Karthik Nayak
2015-07-20 0:02 ` Eric Sunshine
2015-07-20 15:17 ` Karthik Nayak
2015-07-18 19:12 ` [PATCH v3 4/9] ref-filter: add support to sort by version Karthik Nayak
2015-07-20 1:39 ` Eric Sunshine
2015-07-20 16:34 ` Karthik Nayak
2015-07-18 19:12 ` [PATCH v3 5/9] ref-filter: add option to match literal pattern Karthik Nayak
2015-07-20 6:24 ` Eric Sunshine
2015-07-20 8:01 ` Christian Couder
2015-07-20 18:12 ` Eric Sunshine
2015-07-21 19:27 ` Karthik Nayak
2015-07-22 19:20 ` Matthieu Moy
2015-07-18 19:12 ` [PATCH v3 6/9] tag.c: use 'ref-filter' data structures Karthik Nayak
2015-07-18 22:00 ` [PATCH v3 7/9] tag.c: use 'ref-filter' APIs Karthik Nayak
2015-07-18 22:00 ` [PATCH v3 8/9] tag.c: implement '--format' option Karthik Nayak
2015-07-22 19:38 ` Matthieu Moy [this message]
2015-07-18 22:00 ` [PATCH v3 9/9] tag.c: implement '--merged' and '--no-merged' options Karthik Nayak
2015-07-19 19:20 ` Christian Couder
2015-07-21 19:28 ` Karthik Nayak
2015-07-22 19:40 ` Matthieu Moy
2015-07-23 16:20 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq7fpsnft1.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=karthik.188@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox