From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Karthik Nayak <karthik.188@gmail•com>
Cc: git@vger•kernel.org, christian.couder@gmail•com
Subject: Re: [PATCH v3 5/9] ref-filter: add option to match literal pattern
Date: Wed, 22 Jul 2015 21:20:20 +0200 [thread overview]
Message-ID: <vpqmvyongnf.fsf@anie.imag.fr> (raw)
In-Reply-To: <1437246749-14423-6-git-send-email-Karthik.188@gmail.com> (Karthik Nayak's message of "Sun, 19 Jul 2015 00:42:25 +0530")
Karthik Nayak <karthik.188@gmail•com> writes:
> --- a/ref-filter.c
> +++ b/ref-filter.c
> @@ -943,9 +943,23 @@ static int commit_contains(struct ref_filter *filter, struct commit *commit)
>
> /*
> * Return 1 if the refname matches one of the patterns, otherwise 0.
> + * A pattern can be a literal prefix (e.g. a refname "refs/heads/master"
> + * matches a pattern "refs/heads/m") or a wildcard (e.g. the same ref
> + * matches "refs/heads/m*", too).
> + */
> +static int match_pattern(const char **patterns, const char *refname)
> +{
> + for (; *patterns; patterns++)
> + if (!wildmatch(*patterns, refname, 0, NULL))
> + return 1;
> + return 0;
> +}
> +
> +/*
> + * Return 1 if the refname matches one of the patterns, otherwise 0.
> * A pattern can be path prefix (e.g. a refname "refs/heads/master"
> * matches a pattern "refs/heads/") or a wildcard (e.g. the same ref
While you're there, why not say explicitly
* A pattern can be path prefix (e.g. a refname "refs/heads/master"
* matches a pattern "refs/heads/" but not "refs/heads/m")
^^^^^^^^^^^^^^^^^^^^^^
...
(I find it frustrating when the docstrings for two function look
identical and I have to find out the 1-character difference to
understand ...)
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-07-22 19:20 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-18 19:12 [PATCH v3 0/9] Port tag.c to use ref-filter APIs Karthik Nayak
2015-07-18 19:12 ` [PATCH v3 1/9] ref-filter: add option to align atoms to the left Karthik Nayak
2015-07-19 23:49 ` Eric Sunshine
2015-07-20 15:06 ` Karthik Nayak
2015-07-20 16:12 ` Junio C Hamano
2015-07-20 17:47 ` Eric Sunshine
2015-07-20 16:37 ` Junio C Hamano
2015-07-20 17:04 ` Karthik Nayak
2015-07-20 17:22 ` Karthik Nayak
2015-07-20 18:01 ` Eric Sunshine
2015-07-20 18:23 ` Karthik Nayak
2015-07-20 17:29 ` Junio C Hamano
2015-07-21 18:00 ` Karthik Nayak
2015-07-22 18:44 ` Matthieu Moy
2015-07-23 14:32 ` Karthik Nayak
2015-07-18 19:12 ` [PATCH v3 2/9] ref-filter: add option to filter only tags Karthik Nayak
2015-07-18 19:12 ` [PATCH v3 3/9] ref-filter: support printing N lines from tag annotation Karthik Nayak
2015-07-20 0:02 ` Eric Sunshine
2015-07-20 15:17 ` Karthik Nayak
2015-07-18 19:12 ` [PATCH v3 4/9] ref-filter: add support to sort by version Karthik Nayak
2015-07-20 1:39 ` Eric Sunshine
2015-07-20 16:34 ` Karthik Nayak
2015-07-18 19:12 ` [PATCH v3 5/9] ref-filter: add option to match literal pattern Karthik Nayak
2015-07-20 6:24 ` Eric Sunshine
2015-07-20 8:01 ` Christian Couder
2015-07-20 18:12 ` Eric Sunshine
2015-07-21 19:27 ` Karthik Nayak
2015-07-22 19:20 ` Matthieu Moy [this message]
2015-07-18 19:12 ` [PATCH v3 6/9] tag.c: use 'ref-filter' data structures Karthik Nayak
2015-07-18 22:00 ` [PATCH v3 7/9] tag.c: use 'ref-filter' APIs Karthik Nayak
2015-07-18 22:00 ` [PATCH v3 8/9] tag.c: implement '--format' option Karthik Nayak
2015-07-22 19:38 ` Matthieu Moy
2015-07-18 22:00 ` [PATCH v3 9/9] tag.c: implement '--merged' and '--no-merged' options Karthik Nayak
2015-07-19 19:20 ` Christian Couder
2015-07-21 19:28 ` Karthik Nayak
2015-07-22 19:40 ` Matthieu Moy
2015-07-23 16:20 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqmvyongnf.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=karthik.188@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox