From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Paul Tan <pyokagan@gmail•com>
Cc: Luis Ressel <aranea@aixah•de>,
git@vger•kernel.org,
Christian Couder <christian.couder@gmail•com>
Subject: Re: [GSoC microproject] Add XDG support to the credential-store helper
Date: Fri, 06 Mar 2015 18:28:57 +0100 [thread overview]
Message-ID: <vpqa8zq9grq.fsf@anie.imag.fr> (raw)
In-Reply-To: <CACRoPnR3i3pTyqcxm0iELP0uR9cL2kvm9fd7BQPVpbLB0UBNVw@mail.gmail.com> (Paul Tan's message of "Fri, 6 Mar 2015 16:04:39 +0800")
Paul Tan <pyokagan@gmail•com> writes:
> Hi Luis,
>
> On Fri, Mar 6, 2015 at 7:41 AM, Luis Ressel <aranea@aixah•de> wrote:
>> Okay, I've had a look at Paul's patch for this. Sorry again for the
>> dupe, I must've missed it before. I guess I'll attempt another
>> microproject.
>>
>> However, I feel like my patch is really all that's neccessary; I don't
>> think we should try to use both files if they exist -- I consider
>> Paul's approach to be a bit overcomplicated.
>>
>> My patch still uses ~/.git-credentials as a default location, which
>> should be sufficient for compability.
>
> Indeed, that was my initial plan for implementation as well[1]. Matthieu,
> however, wanted the behavior to follow that of git-config[2].
The fact that I suggested doing it this way does not mean it _has_ to be
done this way. Decisions are taken by trying to reach a consensus with
discussion, so everyone is welcome to argue.
I don't remember all the discussions we had about the ~/.gitconfig, but
one issue with considering only one file is if you create
~/.git/config/foo and initially make sure you don't have ~/.gitfoo, and
then one tool creates ~/.gitfoo (either an old Git, or another tool
trying to edit the config file), then you totally break your
configuration.
I argued for not taking backward compatibility too much into account in
another thread, but that was about precedence of one file over the other
which is far less important. Here, any tool creating even an empty home
file would break your configuration.
That also breaks the least surprise principle if you have a ~/.gitfoo
file that you forgot about: edit ~/.config/git/foo, nothing is taken
into account, at all (or the other way around, depending on the
precedence you choose). I remember loosing some time with two vlc
configuration files like this.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-03-06 17:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 20:51 [GSoC microproject] Add XDG support to the credential-store helper Luis Ressel
2015-03-05 20:53 ` [PATCH] " Luis Ressel
2015-03-05 22:10 ` [GSoC microproject] " Junio C Hamano
2015-03-05 22:38 ` Christian Couder
2015-03-05 23:15 ` Luis Ressel
2015-03-05 23:41 ` Luis Ressel
2015-03-06 8:04 ` Paul Tan
2015-03-06 17:28 ` Matthieu Moy [this message]
2015-03-06 19:21 ` Paul Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqa8zq9grq.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=aranea@aixah$(echo .)de \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pyokagan@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox