From: Junio C Hamano <gitster@pobox•com>
To: Luis Ressel <aranea@aixah•de>
Cc: git@vger•kernel.org
Subject: Re: [GSoC microproject] Add XDG support to the credential-store helper
Date: Thu, 05 Mar 2015 14:10:35 -0800 [thread overview]
Message-ID: <xmqqsidj14f8.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150305215146.394caa71@gentp.lnet> (Luis Ressel's message of "Thu, 5 Mar 2015 21:51:46 +0100")
Luis Ressel <aranea@aixah•de> writes:
> Oh, and should I add a testcase for the new functionality introduced by
> this patch? And if yes, what exactly should I test?
Absolutely.
Thinking things through to design what needs to be tested is part of
the exercise ;-) You need to demonstrate that the new feature kicks
in when it should, and also you need to make sure the new feature
does not get used when it shouldn't.
next prev parent reply other threads:[~2015-03-05 22:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 20:51 [GSoC microproject] Add XDG support to the credential-store helper Luis Ressel
2015-03-05 20:53 ` [PATCH] " Luis Ressel
2015-03-05 22:10 ` Junio C Hamano [this message]
2015-03-05 22:38 ` [GSoC microproject] " Christian Couder
2015-03-05 23:15 ` Luis Ressel
2015-03-05 23:41 ` Luis Ressel
2015-03-06 8:04 ` Paul Tan
2015-03-06 17:28 ` Matthieu Moy
2015-03-06 19:21 ` Paul Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsidj14f8.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=aranea@aixah$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox