From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Karthik Nayak <karthik.188@gmail•com>
Cc: git@vger•kernel.org, christian.couder@gmail•com
Subject: Re: [WIP/PATCH v5 02/10] for-each-ref: clean up code
Date: Mon, 08 Jun 2015 16:37:25 +0200 [thread overview]
Message-ID: <vpqd2168dwa.fsf@anie.imag.fr> (raw)
In-Reply-To: <1433574581-23980-2-git-send-email-karthik.188@gmail.com> (Karthik Nayak's message of "Sat, 6 Jun 2015 12:39:33 +0530")
Karthik Nayak <karthik.188@gmail•com> writes:
> In 'grab_single_ref()' remove the extra count variable 'cnt' and
> use the variable 'grab_cnt' of structure 'grab_ref_cbdata' directly
> instead.
>
> Change comment in 'struct ref_sort' to reflect changes in code.
I don't see how the comment change is related to the code change:
> struct ref_sort {
> struct ref_sort *next;
> - int atom; /* index into used_atom array */
> + int atom; /* index into 'struct atom_value *' array */
> unsigned reverse : 1;
> };
>
> @@ -881,7 +881,6 @@ static int grab_single_ref(const char *refname, const unsigned char *sha1, int f
> {
> struct grab_ref_cbdata *cb = cb_data;
> struct refinfo *ref;
> - int cnt;
>
> if (flag & REF_BAD_NAME) {
> warning("ignoring ref with broken name %s", refname);
> @@ -898,10 +897,8 @@ static int grab_single_ref(const char *refname, const unsigned char *sha1, int f
> */
> ref = new_refinfo(refname, sha1, flag);
>
> - cnt = cb->grab_cnt;
> - REALLOC_ARRAY(cb->grab_array, cnt + 1);
> - cb->grab_array[cnt++] = ref;
> - cb->grab_cnt = cnt;
> + REALLOC_ARRAY(cb->grab_array, cb->grab_cnt + 1);
> + cb->grab_array[cb->grab_cnt++] = ref;
> return 0;
> }
Did you squash the comment change into the wrong commit?
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-06-08 14:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-06 7:04 [WIP/PATCH v5 0/10] create ref-filter from for-each-ref Karthik Nayak
2015-06-06 7:09 ` [WIP/PATCH v5 01/10] for-each-ref: extract helper functions out of grab_single_ref() Karthik Nayak
2015-06-06 7:09 ` [WIP/PATCH v5 02/10] for-each-ref: clean up code Karthik Nayak
2015-06-08 14:37 ` Matthieu Moy [this message]
2015-06-08 15:21 ` Karthik Nayak
2015-06-08 16:23 ` Matthieu Moy
2015-06-06 7:09 ` [WIP/PATCH v5 03/10] for-each-ref: rename 'refinfo' to 'ref_array_item' Karthik Nayak
2015-06-08 14:42 ` Matthieu Moy
2015-06-08 15:19 ` Karthik Nayak
2015-06-06 7:09 ` [WIP/PATCH v5 04/10] for-each-ref: introduce new structures for better organisation Karthik Nayak
2015-06-06 7:09 ` [WIP/PATCH v5 05/10] for-each-ref: introduce 'ref_array_clear()' Karthik Nayak
2015-06-08 14:53 ` Matthieu Moy
2015-06-08 15:18 ` Karthik Nayak
2015-06-08 15:18 ` Karthik Nayak
2015-06-08 16:26 ` Matthieu Moy
2015-06-08 17:05 ` Junio C Hamano
2015-06-08 17:21 ` Matthieu Moy
2015-06-08 20:19 ` Karthik Nayak
2015-06-09 6:31 ` Matthieu Moy
2015-06-06 7:09 ` [WIP/PATCH v5 06/10] for-each-ref: rename some functions and make them public Karthik Nayak
2015-06-06 7:09 ` [WIP/PATCH v5 07/10] ref-filter: add 'ref-filter.h' Karthik Nayak
2015-06-06 7:09 ` [WIP/PATCH v5 08/10] ref-filter: move code from 'for-each-ref' Karthik Nayak
2015-06-06 7:09 ` [WIP/PATCH v5 09/10] for-each-ref: introduce filter_refs() Karthik Nayak
2015-06-06 7:09 ` [WIP/PATCH v5 10/10] ref-filter: make 'ref_array_item' use a FLEX_ARRAY for refname Karthik Nayak
2015-06-06 9:40 ` [WIP/PATCH v5 0/10] create ref-filter from for-each-ref Christian Couder
2015-06-06 10:53 ` Karthik Nayak
2015-06-06 11:26 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqd2168dwa.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=karthik.188@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox