From: Junio C Hamano <gitster@pobox•com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
Cc: Karthik Nayak <karthik.188@gmail•com>,
git@vger•kernel.org, christian.couder@gmail•com
Subject: Re: [WIP/PATCH v5 05/10] for-each-ref: introduce 'ref_array_clear()'
Date: Mon, 08 Jun 2015 10:05:19 -0700 [thread overview]
Message-ID: <xmqq3822cer4.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <vpqbngq2mkw.fsf@anie.imag.fr> (Matthieu Moy's message of "Mon, 08 Jun 2015 18:26:23 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp•fr> writes:
> Karthik Nayak <karthik.188@gmail•com> writes:
>
>> On 06/08/2015 08:23 PM, Matthieu Moy wrote:
>>> Karthik Nayak <karthik.188@gmail•com> writes:
>>>
>>> > +/* Free all memory allocated for ref_array */
>>> > +void ref_array_clear(struct ref_array *array)
>>>
>>> Is this a private function? If so, then add static. If not, you probably
>>> want to export it in a .h file.
>>>
>> It is in ref-filter.h.
>
> Ah, OK. It comes later in the series.
Confused I am; if it comes later not in the same patch then it is
not OK, is it?
next prev parent reply other threads:[~2015-06-08 17:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-06 7:04 [WIP/PATCH v5 0/10] create ref-filter from for-each-ref Karthik Nayak
2015-06-06 7:09 ` [WIP/PATCH v5 01/10] for-each-ref: extract helper functions out of grab_single_ref() Karthik Nayak
2015-06-06 7:09 ` [WIP/PATCH v5 02/10] for-each-ref: clean up code Karthik Nayak
2015-06-08 14:37 ` Matthieu Moy
2015-06-08 15:21 ` Karthik Nayak
2015-06-08 16:23 ` Matthieu Moy
2015-06-06 7:09 ` [WIP/PATCH v5 03/10] for-each-ref: rename 'refinfo' to 'ref_array_item' Karthik Nayak
2015-06-08 14:42 ` Matthieu Moy
2015-06-08 15:19 ` Karthik Nayak
2015-06-06 7:09 ` [WIP/PATCH v5 04/10] for-each-ref: introduce new structures for better organisation Karthik Nayak
2015-06-06 7:09 ` [WIP/PATCH v5 05/10] for-each-ref: introduce 'ref_array_clear()' Karthik Nayak
2015-06-08 14:53 ` Matthieu Moy
2015-06-08 15:18 ` Karthik Nayak
2015-06-08 15:18 ` Karthik Nayak
2015-06-08 16:26 ` Matthieu Moy
2015-06-08 17:05 ` Junio C Hamano [this message]
2015-06-08 17:21 ` Matthieu Moy
2015-06-08 20:19 ` Karthik Nayak
2015-06-09 6:31 ` Matthieu Moy
2015-06-06 7:09 ` [WIP/PATCH v5 06/10] for-each-ref: rename some functions and make them public Karthik Nayak
2015-06-06 7:09 ` [WIP/PATCH v5 07/10] ref-filter: add 'ref-filter.h' Karthik Nayak
2015-06-06 7:09 ` [WIP/PATCH v5 08/10] ref-filter: move code from 'for-each-ref' Karthik Nayak
2015-06-06 7:09 ` [WIP/PATCH v5 09/10] for-each-ref: introduce filter_refs() Karthik Nayak
2015-06-06 7:09 ` [WIP/PATCH v5 10/10] ref-filter: make 'ref_array_item' use a FLEX_ARRAY for refname Karthik Nayak
2015-06-06 9:40 ` [WIP/PATCH v5 0/10] create ref-filter from for-each-ref Christian Couder
2015-06-06 10:53 ` Karthik Nayak
2015-06-06 11:26 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq3822cer4.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=karthik.188@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox