From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail•com>
Cc: Heiko Voigt <hvoigt@hvoigt•net>, git <git@vger•kernel.org>,
"Shawn O. Pearce" <spearce@spearce•org>,
Pat Thoyts <patthoyts@users•sourceforge.net>
Subject: Re: [BUG] git gui blame: Show History Context broken since 29e5573d
Date: Tue, 23 Feb 2010 07:40:16 +0100 [thread overview]
Message-ID: <vpqiq9omp4f.fsf@bauges.imag.fr> (raw)
In-Reply-To: <cb7bb73a1002221529r6aee3202l5b6609b59aea01fd@mail.gmail.com> (Giuseppe Bilotta's message of "Tue\, 23 Feb 2010 00\:29\:03 +0100")
[ Adding Pat Thoyts, author of the first patch, in Cc ]
Giuseppe Bilotta <giuseppe.bilotta@gmail•com> writes:
> On Mon, Feb 22, 2010 at 11:38 PM, Heiko Voigt <hvoigt@hvoigt•net> wrote:
>> On Mon, Feb 22, 2010 at 04:18:11PM +0100, Giuseppe Bilotta wrote:
>>> On Mon, Feb 22, 2010 at 9:27 AM, Matthieu Moy
>>> <Matthieu.Moy@grenoble-inp•fr> wrote:
>>> > Hi,
>>> >
>>> > In "git gui blame", right-clicking on the left fringe and chosing
>>> > "Show History Context" in the context-menu doesn't work for me in the
>>> > latest git. It says:
>>> >
>>> > couldn't change working directory to "": no such file or directory
>>>
>>> Definitely my fault. _gitworktree was not being set up correctly when
>>> support for bare repositories was enabled and the repo was not bare
>>> (like in the blame case). Patch incoming, can you see if it does the
>>> job for you? It seems to fix it here.
[ patch available here :
http://thread.gmane.org/gmane.comp.version-control.git/140688 ]
>> Isn't this the same bug as this one fixes:
>>
>> http://article.gmane.org/gmane.comp.version-control.git/140288
It seems it is, yes.
> I believe my fix to be more correct in this regard.
Not familiar enought with the code to say which is the right one.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2010-02-23 6:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 8:27 [BUG] git gui blame: Show History Context broken since 29e5573d Matthieu Moy
2010-02-22 15:18 ` Giuseppe Bilotta
2010-02-22 22:38 ` Heiko Voigt
2010-02-22 23:29 ` Giuseppe Bilotta
2010-02-23 6:40 ` Matthieu Moy [this message]
2010-02-23 21:30 ` Heiko Voigt
2010-02-22 15:19 ` [PATCH] git-gui: fix worktree initialization with empty prefix Giuseppe Bilotta
2010-02-22 15:32 ` Matthieu Moy
2010-02-22 15:39 ` Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqiq9omp4f.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=giuseppe.bilotta@gmail$(echo .)com \
--cc=hvoigt@hvoigt$(echo .)net \
--cc=patthoyts@users$(echo .)sourceforge.net \
--cc=spearce@spearce$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox