From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Remi Galan Alfonso <remi.galan-alfonso@ensimag•grenoble-inp.fr>
Cc: Junio C Hamano <gitster@pobox•com>,
Git List <git@vger•kernel.org>,
Remi Lespinet <remi.lespinet@ensimag•grenoble-inp.fr>,
Guillaume Pages <guillaume.pages@ensimag•grenoble-inp.fr>,
Louis-Alexandre Stuber
<louis--alexandre.stuber@ensimag•grenoble-inp.fr>,
Antoine Delaite <antoine.delaite@ensimag•grenoble-inp.fr>,
Johannes Schindelin <johannes.schindelin@gmx•de>,
Stefan Beller <sbeller@google•com>,
Philip Oakley <philipoakley@iee•org>,
Eric Sunshine <sunshine@sunshineco•com>,
Stephen Kelly <steveire@gmail•com>
Subject: Re: [PATCH/RFCv2 1/2] git-rebase -i: add command "drop" to remove a commit
Date: Mon, 01 Jun 2015 20:36:01 +0200 [thread overview]
Message-ID: <vpqoakz1dke.fsf@anie.imag.fr> (raw)
In-Reply-To: <563732680.250935.1433180720935.JavaMail.zimbra@ensimag.grenoble-inp.fr> (Remi Galan Alfonso's message of "Mon, 1 Jun 2015 19:45:20 +0200 (CEST)")
Remi Galan Alfonso <remi.galan-alfonso@ensimag•grenoble-inp.fr> writes:
> Junio C Hamano <gitster@pobox•com> writes:
>> Is this sufficient?
>
>> If you are going to do something in 2/2 that relies on the format of
>> this line being correct (as opposed to "noop" or "#" that can have
>> any garbage on the remainder of the line), wouldn't you want to at
>> least check $sha1 is sensible?
>
> That's also something that I was wondering, I wrote about it in the
> 0/2 part of this patch, I wanted some opinion about it.
Ideally, I think we should do a sanity check before starting the rebase,
and error out if we encounter an invalid command, a command that should
be followed by a valid sha1 and does not, ...
But currently, we do the verification while applying commands, and I
don't think there's anything really helpful to do if we encounter a
"drop this-is-not-a-sha1" command.
So, IMHO, why not do this check, but I'm not sure it will actually help
much.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-06-01 18:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 9:57 [PATCH/RFCv2 0/2] rebase -i : drop command and removed commits Galan Rémi
2015-06-01 9:57 ` [PATCH/RFCv2 1/2] git-rebase -i: add command "drop" to remove a commit Galan Rémi
2015-06-01 16:39 ` Junio C Hamano
2015-06-01 17:06 ` Matthieu Moy
2015-06-01 17:45 ` Remi Galan Alfonso
2015-06-01 18:36 ` Matthieu Moy [this message]
2015-06-02 7:23 ` Remi Galan Alfonso
2015-06-02 7:45 ` Matthieu Moy
2015-06-02 17:14 ` Junio C Hamano
2015-06-03 9:13 ` Remi Galan Alfonso
2015-06-03 17:52 ` Junio C Hamano
2015-06-01 9:57 ` [PATCH/RFCv2 2/2] git rebase -i: warn about removed commits Galan Rémi
-- strict thread matches above, loose matches on Subject: below --
2015-06-01 11:52 [PATCH/RFCv2 1/2] git-rebase -i: add command "drop" to remove a commit Galan Rémi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqoakz1dke.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=antoine.delaite@ensimag$(echo .)grenoble-inp.fr \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=guillaume.pages@ensimag$(echo .)grenoble-inp.fr \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=louis--alexandre.stuber@ensimag$(echo .)grenoble-inp.fr \
--cc=philipoakley@iee$(echo .)org \
--cc=remi.galan-alfonso@ensimag$(echo .)grenoble-inp.fr \
--cc=remi.lespinet@ensimag$(echo .)grenoble-inp.fr \
--cc=sbeller@google$(echo .)com \
--cc=steveire@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox