From: Matthieu Moy <Matthieu.Moy@imag•fr>
To: Pascal Obry <pascal@obry•net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx•de>,
Pascal Obry <pascal.obry@gmail•com>,
git@vger•kernel.org
Subject: Re: [PATCH] Teach diff machinery to display other prefixes than "a/" and "b/"
Date: Tue, 18 Dec 2007 18:02:43 +0100 [thread overview]
Message-ID: <vpqprx4uea4.fsf@bauges.imag.fr> (raw)
In-Reply-To: <4767F935.8060207@obry.net> (Pascal Obry's message of "Tue\, 18 Dec 2007 17\:45\:41 +0100")
Pascal Obry <pascal@obry•net> writes:
> Johannes Schindelin a écrit :
>> With the new option "--prefix=<prefix1>[:<prefix2>]" you can change
>> the shown prefix, or suppress it (by specifying the empty string).
>
> Why not ? But do you have a motivation for this change ? I mean why
> would you want to use a completely different prefix ?
It can make sense when you send the patch to someone who might not
know the context in which you wrote the patch, and who's not using
git. Then
--- your-version/foo.c
+++ my-version/foo.c
can be more expressive than a/ and b/. Some people like to have orig/
and mod/ also.
I can live without --prefix=... option, but doing it general at once
is a good idea, since adding this backward-compatibly on top of your
patch would mean having several redundant options.
--
Matthieu
prev parent reply other threads:[~2007-12-18 17:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-18 15:42 [PATCH] Add format-patch option --no-name-prefix Pascal Obry
2007-12-18 15:47 ` Pascal Obry
2007-12-18 15:54 ` Johannes Sixt
2007-12-18 15:59 ` Pascal Obry
2007-12-18 16:50 ` Linus Torvalds
2007-12-18 16:54 ` Pascal Obry
2007-12-18 17:06 ` Johannes Schindelin
2007-12-18 17:56 ` Pascal Obry
2007-12-18 18:56 ` [PATCH] Teach diff machinery to display other prefixes than "a/" and "b/" Johannes Schindelin
2007-12-18 19:03 ` Pascal Obry
2007-12-18 19:05 ` Linus Torvalds
2007-12-18 19:32 ` [PATCH v4] " Johannes Schindelin
2007-12-18 19:55 ` Linus Torvalds
2007-12-18 20:07 ` [PATCH] Add format-patch option --no-name-prefix Junio C Hamano
2007-12-18 16:03 ` Andreas Ericsson
2007-12-18 16:11 ` Pascal Obry
2007-12-19 8:55 ` Andreas Ericsson
2007-12-19 9:21 ` Johannes Sixt
2007-12-18 16:21 ` [PATCH] Teach diff machinery to display other prefixes than "a/" and "b/" Johannes Schindelin
2007-12-18 16:45 ` Pascal Obry
2007-12-18 16:58 ` Johannes Schindelin
2007-12-18 17:02 ` Matthieu Moy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqprx4uea4.fsf@bauges.imag.fr \
--to=matthieu.moy@imag$(echo .)fr \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=pascal.obry@gmail$(echo .)com \
--cc=pascal@obry$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox