public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Junio C Hamano <gitster@pobox•com>
Cc: Jonathan Nieder <jrnieder@gmail•com>, Jeff King <peff@peff•net>,
	git@vger•kernel.org
Subject: Re: [PATCH v4 0/5] Disable "git status" comment prefix
Date: Fri, 06 Sep 2013 20:43:59 +0200	[thread overview]
Message-ID: <vpqsixhrdsg.fsf@anie.imag.fr> (raw)
In-Reply-To: <xmqqk3ityg2x.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Fri, 06 Sep 2013 11:12:38 -0700")

Junio C Hamano <gitster@pobox•com> writes:

> Actually, "nothing added ..." is not a part of status proper; it
> will be clear if you run the command with comment prefix, whose
> output may end like so:
>
>     # Untracked files:
>     #   (use "git add <file>..." to include in what will be committed)
>     #
>     #       gomi
>     #       kuzu
>     nothing added to commit but untracked files present (use "git add" to track)
>
> But I agree that the output without comment prefix needs an extra
> blank before that line (if that line will be emitted, that is).

Even when the line is not emitted, we normally do:

# On branch master
# Changes to be committed:
#   (use "git reset HEAD <file>..." to unstage)
#
#	modified:   foo.txt
#

(with the last #-only line), so there's no reason to behave differently
when the last lines are "Untracked files".

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

  reply	other threads:[~2013-09-06 18:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05  9:50 [PATCH v4 0/5] Disable "git status" comment prefix Matthieu Moy
2013-09-05  9:50 ` [PATCH v4 1/5] builtin/stripspace.c: fix broken indentation Matthieu Moy
2013-09-05  9:50 ` [PATCH v4 2/5] wt-status: use argv_array API Matthieu Moy
2013-09-05  9:50 ` [PATCH v4 3/5] submodule summary: ignore --for-status option Matthieu Moy
2013-09-05  9:50 ` [PATCH v4 4/5] status: disable display of '#' comment prefix by default Matthieu Moy
2013-09-05  9:50 ` [PATCH v4 5/5] tests: don't set status.oldStyle file-wide Matthieu Moy
2013-09-05 12:35 ` [PATCH v4 0/5] Disable "git status" comment prefix Matthieu Moy
2013-09-05 19:13 ` Junio C Hamano
2013-09-05 19:36   ` Matthieu Moy
2013-09-05 23:09     ` Junio C Hamano
2013-09-05 23:23     ` Jeff King
2013-09-06 16:44       ` Matthieu Moy
2013-09-06 16:53       ` Jonathan Nieder
2013-09-06 17:28         ` Matthieu Moy
2013-09-06 18:12           ` Junio C Hamano
2013-09-06 18:43             ` Matthieu Moy [this message]
2013-09-06 21:55           ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vpqsixhrdsg.fsf@anie.imag.fr \
    --to=matthieu.moy@grenoble-inp$(echo .)fr \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=jrnieder@gmail$(echo .)com \
    --cc=peff@peff$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox