From: Junio C Hamano <gitster@pobox•com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v4 0/5] Disable "git status" comment prefix
Date: Thu, 05 Sep 2013 16:09:44 -0700 [thread overview]
Message-ID: <xmqqsixig91j.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <vpqioyfukkw.fsf@anie.imag.fr> (Matthieu Moy's message of "Thu, 05 Sep 2013 21:36:47 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp•fr> writes:
> Junio C Hamano <gitster@pobox•com> writes:
>
>> One caveat, though. The name "oldStyle" will become problematic,
>> when we want to remove some wart in the output format long after
>> this "no comment prefix by default" series lands. Some people may
>> expect setting oldStyle=true would give output from 1.8.4 era, while
>> some others would expect that it would give output from 1.8.5 era
>> that does not have comment prefix but still has that wart we will
>> remove down the line.
>
> I'm fine with any name actually (since it is enabled by default, people
> don't need to know the name to benefit from the new output). Maybe
> status.displayCommentPrefix was the best name after all.
Yeah, I think so. It makes it clear what kind of old behaviour the
user is asking for.
next prev parent reply other threads:[~2013-09-05 23:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 9:50 [PATCH v4 0/5] Disable "git status" comment prefix Matthieu Moy
2013-09-05 9:50 ` [PATCH v4 1/5] builtin/stripspace.c: fix broken indentation Matthieu Moy
2013-09-05 9:50 ` [PATCH v4 2/5] wt-status: use argv_array API Matthieu Moy
2013-09-05 9:50 ` [PATCH v4 3/5] submodule summary: ignore --for-status option Matthieu Moy
2013-09-05 9:50 ` [PATCH v4 4/5] status: disable display of '#' comment prefix by default Matthieu Moy
2013-09-05 9:50 ` [PATCH v4 5/5] tests: don't set status.oldStyle file-wide Matthieu Moy
2013-09-05 12:35 ` [PATCH v4 0/5] Disable "git status" comment prefix Matthieu Moy
2013-09-05 19:13 ` Junio C Hamano
2013-09-05 19:36 ` Matthieu Moy
2013-09-05 23:09 ` Junio C Hamano [this message]
2013-09-05 23:23 ` Jeff King
2013-09-06 16:44 ` Matthieu Moy
2013-09-06 16:53 ` Jonathan Nieder
2013-09-06 17:28 ` Matthieu Moy
2013-09-06 18:12 ` Junio C Hamano
2013-09-06 18:43 ` Matthieu Moy
2013-09-06 21:55 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsixig91j.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox