From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Karthik Nayak <karthik.188@gmail•com>
Cc: git@vger•kernel.org, christian.couder@gmail•com, gitster@pobox•com
Subject: Re: [PATCH v15 05/13] ref-filter: implement an `align` atom
Date: Wed, 02 Sep 2015 10:45:33 +0200 [thread overview]
Message-ID: <vpqvbbttdjm.fsf@anie.imag.fr> (raw)
In-Reply-To: <1441131994-13508-6-git-send-email-Karthik.188@gmail.com> (Karthik Nayak's message of "Tue, 1 Sep 2015 23:56:26 +0530")
Karthik Nayak <karthik.188@gmail•com> writes:
> --- a/ref-filter.c
> +++ b/ref-filter.c
> @@ -163,9 +174,28 @@ static void quote_formatting(struct strbuf *s, const char *str, int quote_style)
> }
> }
>
> +static void align_handler(struct ref_formatting_stack *stack)
Perhaps name it end_align_handler, to make the difference with
align_atom_handler clear.
Also, I think moving this function to be right next to
align_atom_handler in the code would make this more readable.
> @@ -754,6 +816,42 @@ static void populate_value(struct ref_array_item *ref)
> else
> v->s = " ";
> continue;
> + } else if (skip_prefix(name, "align", &valp)) {
> + struct align *align = &v->align;
> + struct strbuf **s;
> +
> + if (valp[0] != ':')
> + die(_("format: usage %%(align:<width>,<position>)"));
> + else
> + valp++;
I agree with Junio that skip_prefix(name, "align:" ...) is simpler for
the same thing.
> + if (state.stack->prev)
> + die(_("format: `end` atom missing"));
Perhaps spell it %(end) instead of just end.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-09-02 8:45 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 18:26 [PATCH v15 00/13] port builtin/tag.c to use ref-filter APIs Karthik Nayak
2015-09-01 18:26 ` [PATCH v15 01/13] ref-filter: move `struct atom_value` to ref-filter.c Karthik Nayak
2015-09-01 18:26 ` [PATCH v15 02/13] ref-filter: introduce ref_formatting_state and ref_formatting_stack Karthik Nayak
2015-09-01 18:26 ` [PATCH v15 03/13] utf8: add function to align a string into given strbuf Karthik Nayak
2015-09-01 18:26 ` [PATCH v15 04/13] ref-filter: introduce handler function for each atom Karthik Nayak
2015-09-01 18:26 ` [PATCH v15 05/13] ref-filter: implement an `align` atom Karthik Nayak
2015-09-01 21:19 ` Junio C Hamano
2015-09-02 11:51 ` Karthik Nayak
2015-09-02 15:01 ` Junio C Hamano
2015-09-02 15:05 ` Karthik Nayak
2015-09-02 15:45 ` Junio C Hamano
2015-09-02 16:09 ` Karthik Nayak
2015-09-02 17:10 ` Matthieu Moy
2015-09-02 17:28 ` Junio C Hamano
2015-09-03 13:30 ` Karthik Nayak
2015-09-02 15:50 ` Matthieu Moy
2015-09-02 8:41 ` Matthieu Moy
2015-09-02 12:51 ` Karthik Nayak
2015-09-02 8:45 ` Matthieu Moy [this message]
2015-09-02 13:12 ` Karthik Nayak
2015-09-02 15:50 ` Matthieu Moy
2015-09-03 14:12 ` Eric Sunshine
2015-09-03 16:01 ` Karthik Nayak
2015-09-03 16:23 ` Junio C Hamano
2015-09-04 18:02 ` Karthik Nayak
2015-09-01 18:26 ` [PATCH v15 06/13] ref-filter: add option to filter out tags, branches and remotes Karthik Nayak
2015-09-01 21:30 ` Junio C Hamano
2015-09-02 1:27 ` Karthik Nayak
2015-09-02 4:15 ` Junio C Hamano
2015-09-02 12:48 ` Karthik Nayak
2015-09-01 18:26 ` [PATCH v15 07/13] ref-filter: add support for %(contents:lines=X) Karthik Nayak
2015-09-02 9:07 ` Matthieu Moy
2015-09-02 14:16 ` Karthik Nayak
2015-09-02 16:11 ` Matthieu Moy
2015-09-03 13:34 ` Karthik Nayak
2015-09-03 13:49 ` Karthik Nayak
2015-09-03 14:47 ` Matthieu Moy
2015-09-03 16:05 ` Karthik Nayak
2015-09-03 14:39 ` Eric Sunshine
2015-09-03 14:47 ` Eric Sunshine
2015-09-03 15:05 ` Matthieu Moy
2015-09-03 16:04 ` Karthik Nayak
2015-09-03 16:27 ` Junio C Hamano
2015-09-04 12:35 ` Karthik Nayak
2015-09-03 15:01 ` Matthieu Moy
2015-09-03 16:03 ` Karthik Nayak
2015-09-01 18:26 ` [PATCH v15 08/13] ref-filter: add support to sort by version Karthik Nayak
2015-09-01 18:26 ` [PATCH v15 09/13] ref-filter: add option to match literal pattern Karthik Nayak
2015-09-01 18:26 ` [PATCH v15 10/13] tag.c: use 'ref-filter' data structures Karthik Nayak
2015-09-01 18:26 ` [PATCH v15 11/13] tag.c: use 'ref-filter' APIs Karthik Nayak
2015-09-02 9:09 ` Matthieu Moy
2015-09-02 15:10 ` Junio C Hamano
2015-09-02 15:40 ` Karthik Nayak
2015-09-02 16:13 ` Matthieu Moy
2015-09-02 16:43 ` Junio C Hamano
2015-09-03 13:32 ` Karthik Nayak
2015-09-01 18:26 ` [PATCH v15 12/13] tag.c: implement '--format' option Karthik Nayak
2015-09-01 18:26 ` [PATCH v15 13/13] tag.c: implement '--merged' and '--no-merged' options Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqvbbttdjm.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=karthik.188@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox