From: Junio C Hamano <gitster@pobox•com>
To: Clemens Buchacher <clemens.buchacher@intel•com>
Cc: git@vger•kernel.org, Andrew Wong <andrew.kw.w@gmail•com>,
Jorge Nunes <jorge.nunes@intel•com>
Subject: Re: [PATCH] rebase: return non-zero error code if format-patch fails
Date: Mon, 06 Jul 2015 10:01:28 -0700 [thread overview]
Message-ID: <xmqq1tgl2pav.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150706085326.GA30731@musxeris015.imu.intel.com> (Clemens Buchacher's message of "Mon, 6 Jul 2015 10:53:26 +0200")
Clemens Buchacher <clemens.buchacher@intel•com> writes:
> On Fri, Jul 03, 2015 at 10:52:32AM -0700, Junio C Hamano wrote:
>> >
>> > Cc: Andrew Wong <andrew.kw.w@gmail•com>
>> > Signed-off-by: Clemens Buchacher <clemens.buchacher@intel•com>
>> > Reviewed-by: Jorge Nunes <jorge.nunes@intel•com>
>>
>> Where was this review made? I may have missed a recent discussion,
>> and that is why I am asking, because Reviewed-by: lines that cannot
>> be validated by going back to the list archive does not add much
>> value.
>
> Jorge helped me by reviewing the patch before I submitted it to the
> list. My intention is to give credit for his contribution, and to
> involve him in any discussion regarding the patch. Maybe it makes more
> sense to say Helped-by:?
Thanks; I think that clarifies it, and I think that is how people
seem to use Helped-by around here.
prev parent reply other threads:[~2015-07-06 17:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 9:11 [PATCH] rebase: return non-zero error code if format-patch fails Clemens Buchacher
2015-07-03 17:52 ` Junio C Hamano
2015-07-06 8:53 ` Clemens Buchacher
2015-07-06 17:01 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1tgl2pav.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=andrew.kw.w@gmail$(echo .)com \
--cc=clemens.buchacher@intel$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jorge.nunes@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox