From: Junio C Hamano <gitster@pobox•com>
To: Clemens Buchacher <clemens.buchacher@intel•com>
Cc: git@vger•kernel.org, Andrew Wong <andrew.kw.w@gmail•com>,
Jorge Nunes <jorge.nunes@intel•com>
Subject: Re: [PATCH] rebase: return non-zero error code if format-patch fails
Date: Fri, 03 Jul 2015 10:52:32 -0700 [thread overview]
Message-ID: <xmqqpp493z8f.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150702091133.GA13353@musxeris015.imu.intel.com> (Clemens Buchacher's message of "Thu, 2 Jul 2015 11:11:33 +0200")
Clemens Buchacher <clemens.buchacher@intel•com> writes:
> Since e481af06 (rebase: Handle cases where format-patch fails) we
> notice if format-patch fails and return immediately from
> git-rebase--am. We save the return value with ret=$?, but then we
> return $?, which is usually zero in this case.
>
> Fix this by returning $ret instead.
Sounds sensible.
>
> Cc: Andrew Wong <andrew.kw.w@gmail•com>
> Signed-off-by: Clemens Buchacher <clemens.buchacher@intel•com>
> Reviewed-by: Jorge Nunes <jorge.nunes@intel•com>
Where was this review made? I may have missed a recent discussion,
and that is why I am asking, because Reviewed-by: lines that cannot
be validated by going back to the list archive does not add much
value.
Thanks.
> ---
> git-rebase--am.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-rebase--am.sh b/git-rebase--am.sh
> index f923732..9ae898b 100644
> --- a/git-rebase--am.sh
> +++ b/git-rebase--am.sh
> @@ -78,7 +78,7 @@ else
>
> As a result, git cannot rebase them.
> EOF
> - return $?
> + return $ret
> fi
>
> git am $git_am_opt --rebasing --resolvemsg="$resolvemsg" \
next prev parent reply other threads:[~2015-07-03 17:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 9:11 [PATCH] rebase: return non-zero error code if format-patch fails Clemens Buchacher
2015-07-03 17:52 ` Junio C Hamano [this message]
2015-07-06 8:53 ` Clemens Buchacher
2015-07-06 17:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpp493z8f.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=andrew.kw.w@gmail$(echo .)com \
--cc=clemens.buchacher@intel$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jorge.nunes@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox