From: Junio C Hamano <gitster@pobox•com>
To: Lawrence Siebert <lawrencesiebert@gmail•com>
Cc: git@vger•kernel.org, Johannes.Schindelin@gmx•de,
apelisse@gmail•com, jrnieder@gmail•com
Subject: Re: [PATCH] --count feature for git shortlog
Date: Sun, 28 Jun 2015 21:37:33 -0700 [thread overview]
Message-ID: <xmqq1tgvdt9u.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1435540922-12208-1-git-send-email-lawrencesiebert@gmail.com> (Lawrence Siebert's message of "Sun, 28 Jun 2015 18:22:00 -0700")
Lawrence Siebert <lawrencesiebert@gmail•com> writes:
> This is a new feature for short log, which lets you count commits on a per
> file or repository basis easily.
>
> Currently if you want a total count of commits with shortlog, you would
> need to add up each authors commits after using --summary. This adds a
> -N / --count option to shortlog for this purpose.
The standard way to do that is
git log --oneline ... whatever other args ... | wc -l
or more kosher from a script
git rev-list ... whatever other args ... | wc -l
Adding an option to ignore per-author breakdown smells backwards.
The whole point of shortlog is to give you the commit stats broken
out for each author. I guess it is not so far-fetched to add an
option to "git log" to only show the number of commits that would be
output, if you really wanted to avoid "| wc -l", but this option
does not belong to shortlog.
And it certainly does not deserve a short-and-sweet single letter
option "-N", I think.
next prev parent reply other threads:[~2015-06-29 4:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 1:22 [PATCH] --count feature for git shortlog Lawrence Siebert
2015-06-29 1:22 ` Lawrence Siebert
2015-06-29 1:22 ` Lawrence Siebert
2015-06-29 4:37 ` Junio C Hamano [this message]
[not found] ` <CAKDoJU4HcGoOS83MKwsQBXztYrDomMd9N-2SKc6iRyNhQQM5Eg@mail.gmail.com>
2015-06-29 16:46 ` Lawrence Siebert
2015-06-29 17:04 ` Junio C Hamano
2015-06-29 21:33 ` Lawrence Siebert
2015-06-30 12:10 ` Johannes Schindelin
2015-06-30 12:23 ` John Keeping
[not found] ` <CAKDoJU4cEvWvfnFsvfOJ_P0UOrD3RpLK1NdfxaUPiDTWXYg-oA@mail.gmail.com>
2015-07-01 3:00 ` Lawrence Siebert
2015-07-01 11:50 ` Jeff King
2015-07-01 15:15 ` Junio C Hamano
2015-07-03 17:31 ` Junio C Hamano
2015-07-03 23:32 ` Lawrence Siebert
2015-07-21 18:27 ` Jakub Narębski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1tgvdt9u.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=apelisse@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=lawrencesiebert@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox