public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: John Keeping <john@keeping•me.uk>
Cc: Johannes Schindelin <johannes.schindelin@gmx•de>,
	Lawrence Siebert <lawrencesiebert@gmail•com>,
	git@vger•kernel.org
Subject: Re: [PATCH] --count feature for git shortlog
Date: Fri, 03 Jul 2015 10:31:20 -0700	[thread overview]
Message-ID: <xmqqfv555es7.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150630122323.GY18226@serenity.lan> (John Keeping's message of "Tue, 30 Jun 2015 13:23:24 +0100")

John Keeping <john@keeping•me.uk> writes:

> On Tue, Jun 30, 2015 at 02:10:49PM +0200, Johannes Schindelin wrote:
>> On 2015-06-29 18:46, Lawrence Siebert wrote:
>> 
>> > I appreciate your help. Okay, That all makes sense.
>> > 
>> > I would note that something like:
>> >  git shortlog -s "$FILENAME:  | cut -f 1 | paste -sd+ - | bc
>> > 
>> > seems like it run much faster then:
>> > 
>> >  git log --oneline "$FILENAME" | wc -l
>> 
>> How does it compare to `git rev-list -- "$FILENAME" | wc -l`?
>
> Or even `git rev-list --count HEAD -- "$FILENAME"`.

Ahh, OK.  I didn't know we already had "rev-list --count".

Then please disregard the suggestion to add the option to "log"; it
still holds true that the option does not belong to "shortlog", but
I do think "how many changes were made to this path" statistics
driven by a script should use "rev-list" plumbing, and if it already
has "--count" option, that is perfect ;-)

Thanks.

next prev parent reply	other threads:[~2015-07-03 17:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-29  1:22 [PATCH] --count feature for git shortlog Lawrence Siebert
2015-06-29  1:22 ` Lawrence Siebert
2015-06-29  1:22 ` Lawrence Siebert
2015-06-29  4:37 ` Junio C Hamano
     [not found]   ` <CAKDoJU4HcGoOS83MKwsQBXztYrDomMd9N-2SKc6iRyNhQQM5Eg@mail.gmail.com>
2015-06-29 16:46     ` Lawrence Siebert
2015-06-29 17:04       ` Junio C Hamano
2015-06-29 21:33         ` Lawrence Siebert
2015-06-30 12:10       ` Johannes Schindelin
2015-06-30 12:23         ` John Keeping
     [not found]           ` <CAKDoJU4cEvWvfnFsvfOJ_P0UOrD3RpLK1NdfxaUPiDTWXYg-oA@mail.gmail.com>
2015-07-01  3:00             ` Lawrence Siebert
2015-07-01 11:50               ` Jeff King
2015-07-01 15:15                 ` Junio C Hamano
2015-07-03 17:31           ` Junio C Hamano [this message]
2015-07-03 23:32             ` Lawrence Siebert
2015-07-21 18:27               ` Jakub Narębski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfv555es7.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=johannes.schindelin@gmx$(echo .)de \
    --cc=john@keeping$(echo .)me.uk \
    --cc=lawrencesiebert@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox