From: Junio C Hamano <gitster@pobox•com>
To: git@vger•kernel.org
Subject: [RFH] fedora: pedantic fails complaining that awk is missing
Date: Tue, 15 Apr 2025 16:58:16 -0700 [thread overview]
Message-ID: <xmqq34e9kmef.fsf@gitster.g> (raw)
GitHub Actions CI started failing the pedantic (fedora) job at the
tip of 'master' few days ago, and the log claims the failure is due
to missing "awk". Even though we have seen a few topics to rewrite
Perl scriptlet, and I think at least one of them uses awk, but they
haven't hit 'master' yet, so it is puzzling why this started failing
all of a sudden.
So here is a band-aid. I wouldn't be surprised if the base image
was updated without telling us. We have seen Ubuntu 20.04 base
image retired to cause CI failures as well.
Almalinux does not even seem to have awk available as a package
(or it may be called differently, but we are not suffering from
the lack of awk on that platform anyway), so make sure we ask for
awk only on fedora.
Signed-off-by: Junio C Hamano <gitster@pobox•com>
---
* As the scheduled retirement of U20.04 image broke CI jobs running
for 'master', I started looking at making it pass again with the
minimum change, i.e. by merging dd/sparse-glibc-workaround and
js/ci-github-update-ubuntu topics.
Then I somehow found that another job is broken. And this patch
seems to make it work. Not knowing how it got broken is
unsatisfactory, though.
ci/install-dependencies.sh | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
index 8700c0f292..a7c613ce4c 100755
--- a/ci/install-dependencies.sh
+++ b/ci/install-dependencies.sh
@@ -30,8 +30,10 @@ alpine-*)
bash cvs gnupg perl-cgi perl-dbd-sqlite perl-io-tty >/dev/null
;;
fedora-*|almalinux-*)
+ awk=
+ case "$distro" in fedora-*) awk=awk ;; esac
dnf -yq update >/dev/null &&
- dnf -yq install shadow-utils sudo make gcc findutils diffutils perl python3 gettext zlib-devel expat-devel openssl-devel curl-devel pcre2-devel >/dev/null
+ dnf -yq install shadow-utils sudo make gcc findutils diffutils perl python3 gettext zlib-devel expat-devel openssl-devel curl-devel pcre2-devel $awk >/dev/null
;;
ubuntu-*|i386/ubuntu-*|debian-*)
# Required so that apt doesn't wait for user input on certain packages.
--
2.49.0-511-g173acbf1d8
next reply other threads:[~2025-04-15 23:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 23:58 Junio C Hamano [this message]
2025-04-16 4:40 ` [RFH] fedora: pedantic fails complaining that awk is missing Todd Zullinger
2025-04-16 5:31 ` Johannes Schindelin
2025-04-16 14:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq34e9kmef.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox