From: Junio C Hamano <gitster@pobox•com>
To: Stefan Beller <sbeller@google•com>
Cc: "git\@vger.kernel.org" <git@vger•kernel.org>,
Jens Lehmann <Jens.Lehmann@web•de>,
Jonathan Nieder <jrnieder@gmail•com>
Subject: Re: [PATCH 1/4] git submodule: Teach add to accept --group
Date: Wed, 20 Jan 2016 16:08:40 -0800 [thread overview]
Message-ID: <xmqq37tr3ibb.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kaHLkQpaHOY2aqPgdNvWjmpbuMZSogqzPkkVHRUXyibYw@mail.gmail.com> (Stefan Beller's message of "Wed, 20 Jan 2016 15:57:46 -0800")
Stefan Beller <sbeller@google•com> writes:
>>> @@ -165,6 +166,10 @@ cmd_add()
>>> --depth=*)
>>> depth=$1
>>> ;;
>>> + -g|--group)
>>> + submodule_groups=${submodule_groups:+${submodule_groups};}"$2"
>>> + shift
>>> + ;;
>>
>> You would want to accept "--group=<name>" as well, just like
>> existing --reference and --depth do. It won't be much more code,
>> and when you move to C (hence parse_options) you'd get it for free
>> anyway.
>
> I am not sure, if I will to move `add` to C any time soon. Sure I desire
> less shell and more C[1], but I'd think my time could be spent better than
> just converting scripts to C. Sometimes I have to though, such as in the
> case of `init` as the the call out from C to shell is too ugly and the effort to
> do that is not that much less.
You can do so in less time than you spent making the above 5-line
excuse. It won't be much more code, and it is not ugly at all.
--group=*)
group=$group ${1#--group=} ;;
or something, right?
next prev parent reply other threads:[~2016-01-21 0:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 3:34 [PATCH 0/4] Submodule Groups Stefan Beller
2016-01-20 3:34 ` [PATCH 1/4] git submodule: Teach add to accept --group Stefan Beller
2016-01-20 21:18 ` Junio C Hamano
2016-01-20 23:57 ` Stefan Beller
2016-01-21 0:08 ` Junio C Hamano [this message]
2016-01-21 0:16 ` Stefan Beller
2016-01-21 4:45 ` Junio C Hamano
2016-01-20 3:34 ` [PATCH 2/4] submodule-config: keep groups around Stefan Beller
2016-01-20 21:23 ` Junio C Hamano
2016-01-21 0:20 ` Stefan Beller
2016-01-21 2:37 ` Junio C Hamano
2016-01-20 3:34 ` [PATCH 3/4] submodule update: Initialize all group-selected submodules by default Stefan Beller
2016-01-20 21:30 ` Junio C Hamano
2016-01-21 1:44 ` Stefan Beller
2016-01-21 4:40 ` Junio C Hamano
2016-01-21 19:39 ` Stefan Beller
2016-01-21 20:47 ` Junio C Hamano
2016-01-21 20:57 ` Junio C Hamano
2016-01-20 3:34 ` [PATCH 4/4] builtin/clone: support submodule groups Stefan Beller
2016-01-20 21:43 ` Junio C Hamano
2016-01-21 21:17 ` [PATCH 0/4] Submodule Groups Sebastian Schuberth
2016-01-21 21:56 ` Stefan Beller
2016-01-21 22:18 ` Junio C Hamano
2016-01-21 22:25 ` Junio C Hamano
2016-01-21 22:30 ` Stefan Beller
2016-01-21 22:37 ` Junio C Hamano
2016-01-22 8:55 ` Sebastian Schuberth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq37tr3ibb.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Jens.Lehmann@web$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox