From: Junio C Hamano <gitster@pobox•com>
To: Stefan Beller <sbeller@google•com>
Cc: Sebastian Schuberth <sschuberth@gmail•com>,
"git\@vger.kernel.org" <git@vger•kernel.org>,
Jens Lehmann <Jens.Lehmann@web•de>,
Jonathan Nieder <jrnieder@gmail•com>
Subject: Re: [PATCH 0/4] Submodule Groups
Date: Thu, 21 Jan 2016 14:37:56 -0800 [thread overview]
Message-ID: <xmqqpowuwocb.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kYVE7a=kXi__+Y3C7cuQUhY78o0unuw7vU4hrO71q1dwA@mail.gmail.com> (Stefan Beller's message of "Thu, 21 Jan 2016 14:30:32 -0800")
Stefan Beller <sbeller@google•com> writes:
> I think having both is bad as it may contradict each other?
> What is supposed to happen here:
>
> [submodule "frotz"]
> group = default
>
> [submoduleGroup "default"]
> member = !:frotz
What is supposed to happen is that you will write code to diagnose
this as an error, and give helpful error message to the user.
> So groups of groups, we discovered recursion today. :)
> Having this discussion makes me realize, the groups handling logic
> will be more complex than I anticipated for the first RFC patch series.
That is why I think we do not have to have a very complex group
logic from day one.
> The two basic questions the logic has to answer is:
> * Give me all the submodules that fit these specifiers (i.e. the
> --init-submodules collection from clone)
> * Given submodule X, does it fit the specifier ( a new uninitialized
> submodule during a later update)
Yes.
next prev parent reply other threads:[~2016-01-21 22:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 3:34 [PATCH 0/4] Submodule Groups Stefan Beller
2016-01-20 3:34 ` [PATCH 1/4] git submodule: Teach add to accept --group Stefan Beller
2016-01-20 21:18 ` Junio C Hamano
2016-01-20 23:57 ` Stefan Beller
2016-01-21 0:08 ` Junio C Hamano
2016-01-21 0:16 ` Stefan Beller
2016-01-21 4:45 ` Junio C Hamano
2016-01-20 3:34 ` [PATCH 2/4] submodule-config: keep groups around Stefan Beller
2016-01-20 21:23 ` Junio C Hamano
2016-01-21 0:20 ` Stefan Beller
2016-01-21 2:37 ` Junio C Hamano
2016-01-20 3:34 ` [PATCH 3/4] submodule update: Initialize all group-selected submodules by default Stefan Beller
2016-01-20 21:30 ` Junio C Hamano
2016-01-21 1:44 ` Stefan Beller
2016-01-21 4:40 ` Junio C Hamano
2016-01-21 19:39 ` Stefan Beller
2016-01-21 20:47 ` Junio C Hamano
2016-01-21 20:57 ` Junio C Hamano
2016-01-20 3:34 ` [PATCH 4/4] builtin/clone: support submodule groups Stefan Beller
2016-01-20 21:43 ` Junio C Hamano
2016-01-21 21:17 ` [PATCH 0/4] Submodule Groups Sebastian Schuberth
2016-01-21 21:56 ` Stefan Beller
2016-01-21 22:18 ` Junio C Hamano
2016-01-21 22:25 ` Junio C Hamano
2016-01-21 22:30 ` Stefan Beller
2016-01-21 22:37 ` Junio C Hamano [this message]
2016-01-22 8:55 ` Sebastian Schuberth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpowuwocb.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Jens.Lehmann@web$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=sbeller@google$(echo .)com \
--cc=sschuberth@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox