From: Junio C Hamano <gitster@pobox•com>
To: Sudhanshu Shekhar <sudshekhar02@gmail•com>
Cc: git@vger•kernel.org, Matthieu.Moy@grenoble-inp•fr,
davvid@gmail•com, sunshine@sunshineco•com
Subject: Re: [PATCH v2 1/2] Teach reset the same short-hand as checkout
Date: Mon, 09 Mar 2015 19:34:04 -0700 [thread overview]
Message-ID: <xmqq385d60o3.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1425888936-23370-1-git-send-email-sudshekhar02@gmail.com> (Sudhanshu Shekhar's message of "Mon, 9 Mar 2015 13:45:35 +0530")
Sudhanshu Shekhar <sudshekhar02@gmail•com> writes:
> "-" now means the previous branch.
>
> Signed-off-by: Sudhanshu Shekhar <sudshekhar02@gmail•com>
> Thanks-to: Eric Sunshine, Junio C Hamano, Matthieu Moy
> ---
These look unusual for a few reasons: your S-o-b should be at the
end, we usually say Helped-by: instead, and we do not use these with
multiple names on a single line.
Please do not try to be original without a good reason. We may
start counting the number of times people appear on these footers to
see how much contribution those who do not directly author commits
(read: those who mentor others) are making.
> builtin/reset.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
The comment I gave in the thread that ends at $gmane/265112 would
apply equally to this patch, I think.
cf. http://thread.gmane.org/gmane.comp.version-control.git/264986/focus=265112
next prev parent reply other threads:[~2015-03-10 2:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 8:15 [PATCH v2 1/2] Teach reset the same short-hand as checkout Sudhanshu Shekhar
2015-03-09 8:15 ` [PATCH v2 2/2] Added test cases for git reset - Sudhanshu Shekhar
2015-03-10 2:34 ` Junio C Hamano [this message]
2015-03-10 7:37 ` [PATCH v2 1/2] Teach reset the same short-hand as checkout Sudhanshu Shekhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq385d60o3.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=davvid@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=sudshekhar02@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox