From: Junio C Hamano <gitster@pobox•com>
To: "Torsten Bögershausen" <tboegi@web•de>
Cc: "brian m. carlson" <sandals@crustytoothpaste•net>,
git@vger•kernel.org, lists@hcf•yourweb.de
Subject: Re: [PATCH 1/3] connect.c: Improve parsing of literal IPV6 addresses
Date: Thu, 19 Feb 2015 09:54:52 -0800 [thread overview]
Message-ID: <xmqq386123df.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <54E61285.5070600@web.de> ("Torsten Bögershausen"'s message of "Thu, 19 Feb 2015 17:42:45 +0100")
Torsten Bögershausen <tboegi@web•de> writes:
> On 02/18/2015 07:40 PM, Junio C Hamano wrote:
>> "brian m. carlson" <sandals@crustytoothpaste•net> writes:
>>
>>> I understand that this used to work, but it probably shouldn't have
>>> ever been accepted. It's nonstandard, and if we accept it for ssh,
>>> people will want it to work for https, and due to libcurl, it simply
>>> won't.
>>>
>>> I prefer to see our past acceptance of this format as a bug. This is
>>> the first that I've heard of anyone noticing this (since 2013), so it
>>> can't be in common usage.
>>>
>>> If we accept it, we should explicitly document it as being deprecated
>>> and note that it's inconsistent with the way everything else works.
>> I was reviewing my Undecided pile today, and I think your objection
>> makes sense.
>>
>> Either of you care to update documentation, please, before I drop
>> this series and forget about it?
>
> The URL RFC is much stricter regarding which characters that are allowed
> in which part of the URL, as least as I read it.
> ...
> I'm somewhat unsure what to write in the documentation, I must admit.
I can see that you do not agree with the "If we accept it" part
(where "it" refers to "allowing [...] was a bug.")---past acceptance
was not a bug for you.
Brian is for that "If we accept it", and sees it as a bug.
So let's see what he comes up with as a follow-up to the "we should
explicitly document it" part.
next prev parent reply other threads:[~2015-02-19 17:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 17:21 [PATCH 1/3] connect.c: Improve parsing of literal IPV6 addresses Torsten Bögershausen
2015-01-22 20:07 ` brian m. carlson
2015-01-22 22:05 ` Torsten Bögershausen
2015-01-22 23:41 ` brian m. carlson
2015-02-18 18:40 ` Junio C Hamano
2015-02-19 16:42 ` Torsten Bögershausen
2015-02-19 17:54 ` Junio C Hamano [this message]
2015-02-19 19:40 ` brian m. carlson
2015-02-20 22:11 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq386123df.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=lists@hcf$(echo .)yourweb.de \
--cc=sandals@crustytoothpaste$(echo .)net \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox