public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: "brian m. carlson" <sandals@crustytoothpaste•net>
Cc: "Torsten Bögershausen" <tboegi@web•de>,
	git@vger•kernel.org, lists@hcf•yourweb.de
Subject: Re: [PATCH 1/3] connect.c: Improve parsing of literal IPV6 addresses
Date: Wed, 18 Feb 2015 10:40:07 -0800	[thread overview]
Message-ID: <xmqqtwyj2hdk.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150122234117.GD96498@vauxhall.crustytoothpaste.net> (brian m. carlson's message of "Thu, 22 Jan 2015 23:41:17 +0000")

"brian m. carlson" <sandals@crustytoothpaste•net> writes:

> On Thu, Jan 22, 2015 at 11:05:29PM +0100, Torsten Bögershausen wrote:
>>We want to support ssh://bmc@2001:470:1f05:79::1/git/bmc/homedir.git/
>>   because e.g. the Git shipped with Debian (1.7.10.4) (and a lot of
>> other installations) supports it.
>
> I understand that this used to work, but it probably shouldn't have
> ever been accepted.  It's nonstandard, and if we accept it for ssh,
> people will want it to work for https, and due to libcurl, it simply
> won't.
>
> I prefer to see our past acceptance of this format as a bug.  This is
> the first that I've heard of anyone noticing this (since 2013), so it
> can't be in common usage.
>
> If we accept it, we should explicitly document it as being deprecated
> and note that it's inconsistent with the way everything else works.

I was reviewing my Undecided pile today, and I think your objection
makes sense.

Either of you care to update documentation, please, before I drop
this series and forget about it?

Thanks.

next prev parent reply	other threads:[~2015-02-18 18:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19 17:21 [PATCH 1/3] connect.c: Improve parsing of literal IPV6 addresses Torsten Bögershausen
2015-01-22 20:07 ` brian m. carlson
2015-01-22 22:05   ` Torsten Bögershausen
2015-01-22 23:41     ` brian m. carlson
2015-02-18 18:40       ` Junio C Hamano [this message]
2015-02-19 16:42         ` Torsten Bögershausen
2015-02-19 17:54           ` Junio C Hamano
2015-02-19 19:40             ` brian m. carlson
2015-02-20 22:11               ` Torsten Bögershausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtwyj2hdk.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=lists@hcf$(echo .)yourweb.de \
    --cc=sandals@crustytoothpaste$(echo .)net \
    --cc=tboegi@web$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox