From: Junio C Hamano <gitster@pobox•com>
To: Koosha Khajehmoogahi <koosha@posteo•de>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v2 2/5] log: honor log.merges= option
Date: Tue, 07 Apr 2015 19:28:26 -0700 [thread overview]
Message-ID: <xmqq4morcq0l.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <5524571C.90007@posteo.de> (Koosha Khajehmoogahi's message of "Wed, 08 Apr 2015 00:15:56 +0200")
Koosha Khajehmoogahi <koosha@posteo•de> writes:
> On 04/04/2015 10:00 PM, Junio C Hamano wrote:
>> Koosha Khajehmoogahi <koosha@posteo•de> writes:
>>
>>> From: Junio C Hamano <gitster@pobox•com>
>>>
>>> [kk: wrote commit message]
>>
>> Ehh, what exactly did you write ;-)?
>>
>> I think the most important thing that needs to be explained by the
>> log message for this change is that the variable is honored only by
>> log and it needs to explain why other Porcelain commands in the same
>> "log" family, like "whatchanged", should ignore the variable.
>>
> So, what would be the reason?
It is strange that you have to ask me to give you the reason why you
chose it that way, isn't it?
>> I think that we must not to allow format-patch and show to be
>> affected by this variable, because it is silly if log.merges=only
>> broke format-patch output or made "git show" silent. But I didn't
>> think about others. Whoever is doing this change needs to explain
>> in the log message the reason why it was decided that only "git log"
>> should pay attention to it.
>>
next prev parent reply other threads:[~2015-04-08 2:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <266077>
2015-04-04 1:21 ` [PATCH v2 1/5] revision: add --merges={show|only|hide} option Koosha Khajehmoogahi
2015-04-04 1:21 ` [PATCH v2 2/5] log: honor log.merges= option Koosha Khajehmoogahi
2015-04-04 20:00 ` Junio C Hamano
2015-04-07 22:15 ` Koosha Khajehmoogahi
2015-04-08 2:28 ` Junio C Hamano [this message]
2015-04-08 10:42 ` Koosha Khajehmoogahi
2015-04-13 4:56 ` Junio C Hamano
2015-04-07 5:18 ` Eric Sunshine
2015-04-04 1:21 ` [PATCH v2 3/5] Documentation: add git-log --merges= option and log.merges config. var Koosha Khajehmoogahi
2015-04-05 21:41 ` Junio C Hamano
2015-04-04 1:22 ` [PATCH v2 4/5] t4202-log: add tests for --merges= Koosha Khajehmoogahi
2015-04-07 7:32 ` Eric Sunshine
2015-04-04 1:22 ` [PATCH v2 5/5] bash-completion: add support for git-log --merges= and log.merges Koosha Khajehmoogahi
2015-04-07 5:16 ` [PATCH v2 1/5] revision: add --merges={show|only|hide} option Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4morcq0l.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=koosha@posteo$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox