public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Karsten Blees <karsten.blees@gmail•com>
Cc: Git List <git@vger•kernel.org>, Duy Nguyen <pclouds@gmail•com>
Subject: Re: [PATCH v1 1/3] dir.c: coding style fix
Date: Mon, 14 Jul 2014 15:30:51 -0700	[thread overview]
Message-ID: <xmqq4myjy3ms.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <53C3A71F.1020101@gmail.com> (Karsten Blees's message of "Mon, 14 Jul 2014 11:47:11 +0200")

Karsten Blees <karsten.blees@gmail•com> writes:

> From: =?UTF-8?q?Nguy=E1=BB=85n=20Th=C3=A1i=20Ng=E1=BB=8Dc=20Duy?=
>  <pclouds@gmail•com>
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail•com>
> Signed-off-by: Karsten Blees <blees@dcon•de>
> ---

Thanks for forwarding.   I'll fix-up the Yikes (see how these two
lines show the same name in a very different way), but how did you
produce the above?  Is there some fix we need in the toolchain that
produces patch e-mails?

>  dir.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/dir.c b/dir.c
> index e65888d..3068ca8 100644
> --- a/dir.c
> +++ b/dir.c
> @@ -557,8 +557,7 @@ int add_excludes_from_file_to_list(const char *fname,
>  			buf = xrealloc(buf, size+1);
>  			buf[size++] = '\n';
>  		}
> -	}
> -	else {
> +	} else {
>  		size = xsize_t(st.st_size);
>  		if (size == 0) {
>  			close(fd);
> @@ -793,9 +792,11 @@ static void prep_exclude(struct dir_struct *dir, const char *base, int baselen)
>  
>  	group = &dir->exclude_list_group[EXC_DIRS];
>  
> -	/* Pop the exclude lists from the EXCL_DIRS exclude_list_group
> +	/*
> +	 * Pop the exclude lists from the EXCL_DIRS exclude_list_group
>  	 * which originate from directories not in the prefix of the
> -	 * path being checked. */
> +	 * path being checked.
> +	 */
>  	while ((stk = dir->exclude_stack) != NULL) {
>  		if (stk->baselen <= baselen &&
>  		    !strncmp(dir->basebuf, base, stk->baselen))
> @@ -822,8 +823,7 @@ static void prep_exclude(struct dir_struct *dir, const char *base, int baselen)
>  		if (current < 0) {
>  			cp = base;
>  			current = 0;
> -		}
> -		else {
> +		} else {
>  			cp = strchr(base + current + 1, '/');
>  			if (!cp)
>  				die("oops in prep_exclude");

next prev parent reply	other threads:[~2014-07-14 22:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14  9:47 [PATCH v1 1/3] dir.c: coding style fix Karsten Blees
2014-07-14  9:48 ` [PATCH v1 2/3] dir.h: move struct exclude declaration to top level Karsten Blees
2014-07-14  9:50 ` [PATCH v1 3/3] prep_exclude: remove the artificial PATH_MAX limit Karsten Blees
2014-07-14 22:30 ` Junio C Hamano [this message]
2014-07-15 18:57   ` [PATCH v1 1/3] dir.c: coding style fix Karsten Blees
2014-07-15 19:10     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4myjy3ms.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=karsten.blees@gmail$(echo .)com \
    --cc=pclouds@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox