From: Junio C Hamano <gitster@pobox•com>
To: Karsten Blees <karsten.blees@gmail•com>
Cc: Git List <git@vger•kernel.org>, Duy Nguyen <pclouds@gmail•com>
Subject: Re: [PATCH v1 1/3] dir.c: coding style fix
Date: Tue, 15 Jul 2014 12:10:14 -0700 [thread overview]
Message-ID: <xmqqpph6v3op.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <53C579B4.2050506@gmail.com> (Karsten Blees's message of "Tue, 15 Jul 2014 20:57:56 +0200")
Karsten Blees <karsten.blees@gmail•com> writes:
> Am 15.07.2014 00:30, schrieb Junio C Hamano:
>> Karsten Blees <karsten.blees@gmail•com> writes:
>>
>>> From: =?UTF-8?q?Nguy=E1=BB=85n=20Th=C3=A1i=20Ng=E1=BB=8Dc=20Duy?=
>>> <pclouds@gmail•com>
>>>
>>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail•com>
>>> Signed-off-by: Karsten Blees <blees@dcon•de>
>>> ---
>>
>> Thanks for forwarding. I'll fix-up the Yikes (see how these two
>> lines show the same name in a very different way), but how did you
>> produce the above? Is there some fix we need in the toolchain that
>> produces patch e-mails?
>>
>
> Hmmm...I simply thought that this is how its supposed to work. Mail
> headers can only contain US-ASCII, so the RFC 2047 Q-encoded-word
> generated by git-format-patch looked good to me.
But that quoted one is *NOT* a mail header. It is the first line of
the payload of your message, and should be in plain text just like
the remainder, e.g. S-o-b line that has the same name.
> Perhaps it should be clarified that git-format-patch output is not
> suitable for pasting into mail clients? Or it should print headers
> in plain text and let git-send-email handle the conversions?
If the former is missing, then we should definitely add it to the
documentation. We often see new people pasting the "From " line
meant for /etc/magic and unwanted {From,Subject,Date}: in the body.
We may also want to add an option to tell it to produce an output
that is suitable for pasting into mail clients. Hint, hint...
prev parent reply other threads:[~2014-07-15 19:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 9:47 [PATCH v1 1/3] dir.c: coding style fix Karsten Blees
2014-07-14 9:48 ` [PATCH v1 2/3] dir.h: move struct exclude declaration to top level Karsten Blees
2014-07-14 9:50 ` [PATCH v1 3/3] prep_exclude: remove the artificial PATH_MAX limit Karsten Blees
2014-07-14 22:30 ` [PATCH v1 1/3] dir.c: coding style fix Junio C Hamano
2014-07-15 18:57 ` Karsten Blees
2014-07-15 19:10 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpph6v3op.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=karsten.blees@gmail$(echo .)com \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox