From: Junio C Hamano <gitster@pobox•com>
To: Aditya Garg <gargaditya08@live•com>
Cc: "git@vger•kernel.org" <git@vger•kernel.org>,
Eric Sunshine <sunshine@sunshineco•com>,
"sandals@crustytoothpaste•net" <sandals@crustytoothpaste•net>,
Julian Swagemakers <julian@swagemakers•org>,
Jeff King <peff@peff•net>,
Jacob Keller <jacob.e.keller@intel•com>,
Zi Yao <ziyao@disroot•org>,
Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail•com>
Subject: Re: [PATCH v6 2/2] send-email: show the new message id assigned by outlook in the logs
Date: Thu, 29 May 2025 09:01:15 -0700 [thread overview]
Message-ID: <xmqq5xhjmmno.fsf@gitster.g> (raw)
In-Reply-To: <caf46596a709df7205495b75da569baef2c7c9a2.1748529954.git.gargaditya08@live.com> (Aditya Garg's message of "Thu, 29 May 2025 14:57:04 +0000")
Aditya Garg <gargaditya08@live•com> writes:
> This patch fixes this by modifying the $header variable, which is
> responsible for showing the logs at the end. Also, the log which states
> that the Message-ID has been changed will now be shown only when
> smtp-debug is enabled, since the main log having all of the headers is
> anyways displaying the new Message-ID. It should look like this after
> this patch:
We do not say "This patch does X" or "I do Y" when describing a
change. Rather, you give an order to somebody who is modifying the
codebase to "make it so". Something like ...
Fix this by updating the $header variable, which has the message
ID we internally assigned on the "Message-ID:" header, with the
message ID the Outlook server assigned.
The change itself looks good, but ...
> + # Replace the original Message-ID in $header with the new one
> + $header =~ s/^(Message-ID:\s*).*\n/${1}$message_id\n/m;
... is the comment adding any useful information over what the code
already says?
Will queue, with a typofix to "incrmented" in [1/2].
Thanks.
next prev parent reply other threads:[~2025-05-29 16:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 15:51 [PATCH v4 0/2] send-email: fix threads breaking in case user edits emails and improvements to outlook ID fix Aditya Garg
2025-05-26 15:51 ` [PATCH v4 1/2] send-email: fix bug resulting in increased message number if a message is edited Aditya Garg
2025-05-26 15:51 ` [PATCH v4 2/2] send-email: show the new message id assigned by outlook in the logs Aditya Garg
2025-05-28 6:39 ` [PATCH v5 0/2] send-email: fix threads breaking in case user edits emails and improvements to outlook ID fix Aditya Garg
2025-05-28 6:39 ` [PATCH v5 1/2] send-email: fix bug resulting in increased message number if a message is edited Aditya Garg
2025-05-28 22:52 ` Junio C Hamano
2025-05-29 3:26 ` Aditya Garg
2025-05-28 6:39 ` [PATCH v5 2/2] send-email: show the new message id assigned by outlook in the logs Aditya Garg
2025-05-29 14:57 ` [PATCH v6 0/2] send-email: fix threads breaking in case user edits emails and improvements to outlook ID fix Aditya Garg
2025-05-29 14:57 ` [PATCH v6 1/2] send-email: fix bug resulting in broken threads if a message is edited Aditya Garg
2025-05-29 14:57 ` [PATCH v6 2/2] send-email: show the new message id assigned by outlook in the logs Aditya Garg
2025-05-29 16:01 ` Junio C Hamano [this message]
2025-05-29 16:18 ` Aditya Garg
2025-06-04 12:32 ` Junio C Hamano
2025-06-04 12:55 ` Aditya Garg
2025-06-04 12:55 ` [PATCH v7 0/2] send-email: fix threads breaking in case user edits emails and improvements to outlook ID fix Aditya Garg
2025-06-04 12:55 ` [PATCH v7 1/2] send-email: fix bug resulting in broken threads if a message is edited Aditya Garg
2025-06-04 12:55 ` [PATCH v7 2/2] send-email: show the new message id assigned by outlook in the logs Aditya Garg
2025-06-04 16:31 ` [PATCH v7 0/2] send-email: fix threads breaking in case user edits emails and improvements to outlook ID fix Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5xhjmmno.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=gargaditya08@live$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=julian@swagemakers$(echo .)org \
--cc=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=sandals@crustytoothpaste$(echo .)net \
--cc=sunshine@sunshineco$(echo .)com \
--cc=ziyao@disroot$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox