public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Tobias Klauser <tklauser@distanz•ch>
Cc: Matthieu Moy <Matthieu.Moy@imag•fr>, git@vger•kernel.org
Subject: Re: [PATCH v2 2/4] stripspace: Use parse-options for command-line parsing
Date: Sat, 17 Oct 2015 14:24:13 -0700	[thread overview]
Message-ID: <xmqq6125choi.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20151017103134.GD2468@distanz.ch> (Tobias Klauser's message of "Sat, 17 Oct 2015 12:31:35 +0200")

Tobias Klauser <tklauser@distanz•ch> writes:

> On 2015-10-16 at 19:29:35 +0200, Junio C Hamano <gitster@pobox•com> wrote:
>> Junio C Hamano <gitster@pobox•com> writes:
>> 
>> >> -	if (mode == INVAL)
>> >> -		usage(usage_msg);
>> >
>> > When given "git stripspace -s blorg", we used to set mode to INVAL
>> > and then showed the correct usage.  But we no longer have a check
>> > that corresponds to the old INVAL thing, do we?  Perhaps check argc
>> > to detect presence of an otherwise ignored non-option argument
>> > immediately after parse_options() returns?
>> 
>> Perhaps like this.
>
> Thanks. I'll fold it into v3.

Before starting v3, please fetch from me and check what is queued on
'pu'.  It may turn out that the fix-ups I did while queuing this
round is sufficient, in which case you can just say that instead ;-)

Thanks.

next prev parent reply	other threads:[~2015-10-17 21:24 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16 15:16 [PATCH v2 0/4] stripspace: Implement and use --count-lines option Tobias Klauser
2015-10-16 15:16 ` [PATCH v2 1/4] strbuf: make stripspace() part of strbuf Tobias Klauser
2015-10-16 15:16 ` [PATCH v2 2/4] stripspace: Use parse-options for command-line parsing Tobias Klauser
2015-10-16 17:07   ` Junio C Hamano
2015-10-16 17:29     ` Junio C Hamano
2015-10-17 10:31       ` Tobias Klauser
2015-10-17 21:24         ` Junio C Hamano [this message]
2015-10-20  8:48           ` Tobias Klauser
2015-10-20 15:47             ` Junio C Hamano
2015-10-17 10:30     ` Tobias Klauser
2015-10-16 15:16 ` [PATCH v2 3/4] stripspace: Implement --count-lines option Tobias Klauser
2015-10-17 23:57   ` Eric Sunshine
2015-10-18 17:18     ` Junio C Hamano
2015-10-19 13:46       ` Tobias Klauser
2015-10-19 17:03         ` Christian Couder
2015-10-19 19:24           ` Eric Sunshine
2015-10-19 19:42             ` Matthieu Moy
2015-10-19 13:31     ` Tobias Klauser
2015-10-16 15:16 ` [PATCH v2 4/4] git rebase -i: Use newly added --count-lines option for stripspace Tobias Klauser
2015-10-16 16:41 ` [PATCH v2 0/4] stripspace: Implement and use --count-lines option Junio C Hamano
2015-10-17 10:27   ` Tobias Klauser
2015-10-16 16:54 ` Matthieu Moy
2015-10-17 10:28   ` Tobias Klauser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq6125choi.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=Matthieu.Moy@imag$(echo .)fr \
    --cc=git@vger$(echo .)kernel.org \
    --cc=tklauser@distanz$(echo .)ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox