From: Junio C Hamano <gitster@pobox•com>
To: Namhyung Kim <namhyung@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] stash: Add stash.showFlag config variable
Date: Thu, 27 Aug 2015 18:08:39 -0700 [thread overview]
Message-ID: <xmqq614043u0.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1440683528-11725-1-git-send-email-namhyung@gmail.com> (Namhyung Kim's message of "Thu, 27 Aug 2015 22:52:08 +0900")
Namhyung Kim <namhyung@gmail•com> writes:
> +stash.showFlag::
> + The default option to pass to `git stash show` when no option is
> + given. The default is '--stat'. See description of 'show' command
> + in linkgit:git-stash[1].
Doesn't the same discussion in $gmane/275752 apply here? By
designing the configuration variable in a sloppy way, this change
will force us to spawn "git diff" via the shell forever, even after
somebody ports "git stash" to C.
Which is not great.
Perhaps a pair of new booleans
- stash.showStat (defaults to true but you can turn it off)
- stash.showPatch (defaults to false but you can turn it on)
or something along that line might be sufficient and more palatable.
I dunno.
[Footnote]
*1* Besides, showFlag is a strange configuration variable name. I
thought that by setting it to true, you are making "git stash"
command to somehow show some kind of a flag when it does its
operation ;-).
next prev parent reply other threads:[~2015-08-28 1:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 13:52 [PATCH] stash: Add stash.showFlag config variable Namhyung Kim
2015-08-27 15:20 ` SZEDER Gábor
2015-08-27 15:36 ` Namhyung Kim
2015-08-28 0:16 ` Eric Sunshine
2015-08-28 1:47 ` Namhyung Kim
2015-08-28 1:08 ` Junio C Hamano [this message]
2015-08-28 1:54 ` Namhyung Kim
2015-08-28 18:10 ` Junio C Hamano
2015-08-29 15:19 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq614043u0.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=namhyung@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox