From: Junio C Hamano <gitster@pobox•com>
To: Charles Bailey <charles@hashpling•org>
Cc: Johannes Schindelin <johannes.schindelin@gmx•de>, git@vger•kernel.org
Subject: Re: [PATCH] Fix detection of uname failure
Date: Fri, 17 Jul 2015 10:09:13 -0700 [thread overview]
Message-ID: <xmqq615i3e4m.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150717170142.GA9616@hashpling.org> (Charles Bailey's message of "Fri, 17 Jul 2015 18:01:42 +0100")
Charles Bailey <charles@hashpling•org> writes:
> ... I think '< 0' is
> probably better. In POSIX, we shouldn't ever get a negative value which
> isn't -1, but if we ever do it is probably safer to fail. I'll send and
> update.
Thanks; I was about to type the same reasoning and conclusion ;-)
next prev parent reply other threads:[~2015-07-17 17:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 12:11 [PATCH] Fix detection of uname failure Charles Bailey
2015-07-17 13:06 ` Johannes Schindelin
2015-07-17 17:01 ` Charles Bailey
2015-07-17 17:09 ` Junio C Hamano [this message]
2015-07-17 17:09 ` [PATCH v2] " Charles Bailey
2015-07-17 21:07 ` Johannes Schindelin
2015-07-17 21:39 ` Junio C Hamano
2015-07-18 6:58 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq615i3e4m.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=charles@hashpling$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=johannes.schindelin@gmx$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox